Skip to content

[app-configuration] Fix selecting ConfigurationSetting fields when they contain an underscore #13258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardpark-msft merged 9 commits into from
Jan 20, 2021
Merged

[app-configuration] Fix selecting ConfigurationSetting fields when they contain an underscore #13258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a001a6
Fixing problem where some fields could not be properly `select`'d for…
richardpark-msft Jan 15, 2021
495a2ec
Missed a straggling change.
richardpark-msft Jan 15, 2021
3ab3651
updating with PR
richardpark-msft Jan 15, 2021
afd8d55
add in recording for new test
richardpark-msft Jan 19, 2021
bc10a42
Missing recording for test.
richardpark-msft Jan 19, 2021
2951662
Consistency for the hidden/internal debacle.
richardpark-msft Jan 19, 2021
b8b68e0
Apparently I needed to update more recordings than I realized.
richardpark-msft Jan 20, 2021
1d91e57
Merge remote-tracking branch 'upstream/master' into ac-invalid-filters
richardpark-msft Jan 20, 2021
cf0caf8
Merge branches 'ac-invalid-filters' and 'ac-invalid-filters' of https…
richardpark-msft Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/appconfiguration/app-configuration/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## 1.1.1 (Unreleased)

- Fix issues with `select`ing fields to be returned from `listConfigurationSettings`, `listConfigurationRevisions`
and `getConfigurationSetting` where `last_modified` and `content_type` could not properly be passed in.
[PR #13258](https://github.com/Azure/azure-sdk-for-js/pull/13258)

## 1.1.0 (2020-07-07)

Expand Down
4 changes: 2 additions & 2 deletions sdk/appconfiguration/app-configuration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@
"integration-test:node": "npm run build:test:node && nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace dist-esm/test/*.spec.js dist-esm/test/**/*.spec.js",
"test:browser": "npm run clean && npm run build:test:browser && npm run unit-test:browser",
"test:node": "npm run clean && npm run build:test:node && npm run unit-test:node",
"test": "npm run clean && npm run build:test && npm run unit-test",
"test": "npm run test:node && npm run test:browser",
"unit-test:browser": "",
"unit-test:node": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace test-dist/index.node.js",
"unit-test:node": "npm run build:test:node && mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace test-dist/index.node.js",
"unit-test": "npm run unit-test:node && npm run unit-test:browser",
"docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --stripInternal --mode file --out ./dist/docs ./src"
},
Expand Down
113 changes: 113 additions & 0 deletions .../node/appconfigurationclient_getconfigurationsetting/recording_using_select_via_fields.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading