[core-client] Bugfixes for unblocking data-tables#12547
Merged
xirzec merged 5 commits intoAzure:masterfrom Nov 17, 2020
Merged
Conversation
xirzec
added
Client
deyaaeldeen
reviewed
Nov 16, 2020
Member
deyaaeldeen
left a comment
deyaaeldeen
left a comment
There was a problem hiding this comment.
I think it looks good based on my limited experience. I left a few minor comments.
deyaaeldeen
approved these changes
Nov 16, 2020
joheredi
approved these changes
Nov 17, 2020
Member
joheredi
left a comment
joheredi
left a comment
There was a problem hiding this comment.
Looks awesome! Nice test coverage 😄
| const pairs = queryString.split("&"); | ||
|
|
||
| return pairs.map((pair) => { | ||
| const [name, value] = pair.split("=", 2); |
Member
There was a problem hiding this comment.
nit: this should be equivalent to
return pairs.map((pair) => pari.split("=", 2))
Member
Author
There was a problem hiding this comment.
I did it this way originally, but TS isn't smart enough to know the second parameter limits the size of the result and makes it into a 2 tuple, so it complains:
Type 'string[][]' is not assignable to type '[string, string][]'.
Type 'string[]' is missing the following properties from type '[string, string]': 0, 1
jeremymeng
reviewed
Nov 17, 2020
Member
Author
|
@jeremymeng would you like more time to review this PR or can I merge? 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few things:
core-client.With these changes, I was able to get data-tables to work as expected and pass all integration tests.