[Service Bus] Error from message handler should surface up#1233
Merged
ramya-rao-a merged 4 commits intoAzure:masterfrom Feb 16, 2019
Merged
[Service Bus] Error from message handler should surface up#1233ramya-rao-a merged 4 commits intoAzure:masterfrom
ramya-rao-a merged 4 commits intoAzure:masterfrom
Conversation
ghost
added
the
ramya0820
approved these changes
Feb 15, 2019
Member
ramya0820
left a comment
ramya0820
left a comment
There was a problem hiding this comment.
Great, verified manually that this works.
Contributor
Author
|
@ramya0820 FYI |
HarshaNalluru
pushed a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had previously updated the non session streaming receiver to call the user's error handler when user's onMessage handler throws error. See c94d82b
We missed out on doing the same for the session scenario which resulted in #1190 where we saw that when session lock was lost, then user's message handler could throw an error, but that never surfaced.
This PR is to surface such errors.