[Service Bus] Move settlement method impl out of message#12216
Merged
Conversation
ghost
added
the
ramya-rao-a
requested review from
HarshaNalluru,
chradek and
richardpark-msft
as code owners
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HarshaNalluru
approved these changes
Nov 2, 2020
Member
|
I've got a PR with more or less the same ideas here if you haven't had a chance to see it: #12204 It has some cleanups for the old BatchingReceiverLite, etc... so if we can somehow merge what I have there with this PR then that'd be preferable. or we can just merge the other PR since I think they cover the same ground. |
This was referenced Nov 2, 2020
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2020
In #12216, we moved the code to settle a message and renew its lock from the ServiceBusMessageImpl to the ServiceBusReceiver. After this move, the only dependency left on the ConnectionContext in the ServiceBusMessageImpl is for the DataTransformer. This PR updates the ServiceBusMessage constructor to take the DataTransformer instead of the ConnectionContext and thus remove this dependency altogether. This closes #9944 as we no longer need to track the context or the receiver on the message. This closes #10620 as well. Since the context is not being tracked on the message anymore, it does not matter that the data transformer is tracked on the context.
openapi-sdkautomation Bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 23, 2020
Update readme.python.md (Azure#12216)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to the work done in #11962 and caters to the below point made there
Additionally, it adds checks on peeked messages when one tries to settle them or tries to renew locks for them.