Remove receiver overloads meant to hide settlement methods when using ReceiveAndDelete mode#12014
Merged
Merged
Conversation
ramya-rao-a
requested review from
HarshaNalluru,
bterlson,
chradek,
richardpark-msft and
xirzec
as code owners
ghost
added
the
Contributor
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HarshaNalluru
approved these changes
Oct 23, 2020
|
Hello @ramya-rao-a! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for the changes in the PR #11962
In #11926 we decided not to have the overloads for
createReceiver,acceptSessionandacceptNextSessionmethods that would allow us to hide the message settlement methods if a TypeScript user is using ReceiveAndDelete mode. This PR removes the said overloads that are remnants of #11962