Skip to content

[Identity] Azure Arc, Fabric and ManagedIdentityCredential refactoring #11976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
27 commits merged into from
Nov 4, 2020
Merged

[Identity] Azure Arc, Fabric and ManagedIdentityCredential refactoring #11976

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
26b6f44
wip
sadasant Oct 16, 2020
344b39c
last touches before showing this to jonathan
sadasant Oct 16, 2020
286bfc4
comment and filter->find
sadasant Oct 17, 2020
03fa5c5
no more prepareRequest
sadasant Oct 17, 2020
81356c3
async isAvailable and cached MSI
sadasant Oct 19, 2020
8446f42
Merge remote-tracking branch 'Azure/master' into identity/fix11653
sadasant Oct 19, 2020
66d68cb
formatting
sadasant Oct 19, 2020
12b5b04
MSIs now have isAvailable and getToken, and a sketch of arcMsi
sadasant Oct 20, 2020
ca2aba8
arcMsi code
sadasant Oct 20, 2020
361e282
arc MSI is working
sadasant Oct 21, 2020
d8e2be0
changelog entries
sadasant Oct 21, 2020
c0f881b
Merge remote-tracking branch 'Azure/master' into identity/fix11653
sadasant Oct 22, 2020
a36eb3e
fixed the tests, and added a test for the Arc MSI
sadasant Oct 22, 2020
e6a45c8
small lint fix
sadasant Oct 22, 2020
b0999f9
Merge remote-tracking branch 'Azure/master' into identity/fix11653
sadasant Oct 30, 2020
c2c50fc
pnpm lock updated
sadasant Oct 30, 2020
d981b57
lint fix
sadasant Oct 30, 2020
88e0907
even less precission during the test
sadasant Oct 30, 2020
deda082
Merge remote-tracking branch 'Azure/master' into identity/fix11653
sadasant Nov 2, 2020
3488443
no more 2019 cred, arc fixes, and the fabric code
sadasant Nov 2, 2020
559a2e7
mock-fs
sadasant Nov 2, 2020
03b297a
CHANGELOG change
sadasant Nov 2, 2020
9b8e364
Apply suggestions from code review
sadasant Nov 3, 2020
378477d
arc fix based on recent feedback
sadasant Nov 3, 2020
2bd0ef3
Merge remote-tracking branch 'Azure/master' into identity/fix11653
sadasant Nov 3, 2020
6576924
Catalinas feedback
sadasant Nov 4, 2020
ba453d6
Merge remote-tracking branch 'Azure/master' into identity/fix11653
sadasant Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,006 changes: 1,952 additions & 1,054 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions sdk/identity/identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 1.2.0-beta.3 (Unreleased)

- `ManagedIdentityCredential` now only checks for available MSIs once per class instance.
- `ManagedIdentityCredential` now supports Azure Arc environments.
- Added authority host for multiple clouds on `VisualStudioCodeCredential`, and specified `AzureCloud` as the default cloud name.
- `DeviceCodeCredential` now has both of its constructor parameters, `tenantId` and `clientId`, as optional parameters. The default value of `tenantId` is "organizations", and the Azure CLI's client ID is the default value of `clientId`.

Expand Down
5 changes: 3 additions & 2 deletions sdk/identity/identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"browser": {
"./dist-esm/src/credentials/azureCliCredential.js": "./dist-esm/src/credentials/azureCliCredential.browser.js",
"./dist-esm/src/credentials/environmentCredential.js": "./dist-esm/src/credentials/environmentCredential.browser.js",
"./dist-esm/src/credentials/managedIdentityCredential.js": "./dist-esm/src/credentials/managedIdentityCredential.browser.js",
"./dist-esm/src/credentials/managedIdentityCredential/index.js": "./dist-esm/src/credentials/managedIdentityCredential/index.browser.js",
"./dist-esm/src/credentials/clientCertificateCredential.js": "./dist-esm/src/credentials/clientCertificateCredential.browser.js",
"./dist-esm/src/credentials/deviceCodeCredential.js": "./dist-esm/src/credentials/deviceCodeCredential.browser.js",
"./dist-esm/src/credentials/defaultAzureCredential.js": "./dist-esm/src/credentials/defaultAzureCredential.browser.js",
Expand Down Expand Up @@ -136,6 +136,7 @@
"typescript": "~3.9.3",
"util": "^0.12.1",
"sinon": "^9.0.2",
"@types/sinon": "^9.0.4"
"@types/sinon": "^9.0.4",
"fs-mock": "~1.2.1"

@sophiajt sophiajt Nov 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Called fs-mock here ^

@sadasant sadasant Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

}
}
Loading