[service-bus] Automatically renew message locks when using receiveMessages or getMessageIterator#11658
Merged
richardpark-msft merged 16 commits intoAzure:masterfrom Oct 6, 2020
Conversation
richardpark-msft
requested review from
HarshaNalluru,
bterlson,
chradek,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
Member
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Oct 6, 2020
Contributor
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… at least one test and for compatibility having it off is simpler. We can revisit later - there is coverage for this case in renewLock.spec.ts so it's not untested.
…thub.com/richardpark-msft/azure-sdk-for-js into richardpark-sb-track2-autolocks-iterator
There were a few tests that were relying on the fact that batching didn't use to renew locks (it does now). Changed so each test creates their own receiver, rather than re-using a single one for all tests.
…The renewer already has a great log message in place.
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
…thub.com/richardpark-msft/azure-sdk-for-js into richardpark-sb-track2-autolocks-iterator
Member
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - servicebus |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - servicebus - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the scope of auto-renewal to also include messages received via receiveMessages or getMessageIterator (previously this was only available when you used
subscribe).Fixes #11442