[schema registry] Update to latest swagger#11650
Merged
nguerrera merged 2 commits intoAzure:masterfrom Oct 6, 2020
Merged
Conversation
nguerrera
added
Schema Registry
Client
xirzec
approved these changes
Oct 6, 2020
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Seems like a fine update. text/plain APIs are always a little funny, but it's good that you found misbehavior on the server-side!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to latest swagger for schema registry and react to changes.
The new swagger uses text/plain for schema where the old one used a JSON string. This had an upside and a downside.
Upside: We no longer hit Failure to match test recordings, amount of escaping differs #10659 and we can stop skipping tests
Downside: I hit another bug: Response with text media type is parsed to a JSON object instead of a string #11649. Somehow the response.body is coming back as a parsed JSON object even though it's typed as string. I've worked around it using ._response.bodyAsText pending investigation of that the bug. EDIT: This appears to be due to the service currently responding with Content-Type: application/json still.