[Key Vault Keys] Fixed wrong method in a readme sample #11601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readme sample for the `sign` method of the CryptographyClient was using `signData`. Fixes #11493 @zzhxiaofeng thank you! Reviews appreciated.
ghost
added
the
sadasant
commented
Oct 2, 2020
| console.log("digest: ", digest); | ||
|
|
||
| const signResult = await cryptographyClient.signData("RS256", digest); | ||
| const signResult = await cryptographyClient.sign("RS256", digest); |
Contributor
Author
There was a problem hiding this comment.
Note that this section is indeed in the "Sign" section: https://github.com/Azure/azure-sdk-for-js/pull/11601/files#diff-1c2d798c10ee336ec71c67fc29c2222cR617-R619
Contributor
Author
There was a problem hiding this comment.
Also note that these methods accept the same parameters. Here's a test: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/keyvault-keys/test/public/crypto.spec.ts#L110
ramya-rao-a
approved these changes
Oct 2, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 19, 2020
[ACR] SystemData and new readonly KeyVaultProperties (Azure#11601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme sample for the
signmethod of the CryptographyClient was usingsignData.Fixes #11493
@zzhxiaofeng thank you!
Reviews appreciated.