Skip to content

@Azure/arm-billing - add links#11521

Closed
diberry wants to merge 1 commit intoAzure:masterfrom
diberry:diberry/0927-billing-readme-fix
Closed

@Azure/arm-billing - add links#11521
diberry wants to merge 1 commit intoAzure:masterfrom
diberry:diberry/0927-billing-readme-fix

Conversation

@diberry
Copy link
Copy Markdown
Contributor

@diberry diberry commented Sep 27, 2020

No description provided.

@diberry diberry requested a review from qiaozha as a code owner September 27, 2020 12:47
@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Sep 28, 2020

@ramya-rao-a Is it okay to update the readme.md manually ? will it be overwrtten by codegen?

@ramya-rao-a
Copy link
Copy Markdown
Contributor

ramya-rao-a commented Sep 28, 2020

When this package was last auto generated we were on a very old version of the code generator. You will have to compare the readme here with the one for one of the recently auto generated package to see what the code generator would overwrite the readme with

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Sep 28, 2020

When this package was last auto generated we were on a very old version of the code generator. You will have to compare the readme here with the one for one of the recently auto generated package to see what the code generator would overwrite the readme with

I checkout this PR and generate the arm-billing sdk based on this PR branch with "@microsoft.azure/autorest.typescript@4.4.2". Tt turns out the manual change will be revert

@qiaozha qiaozha mentioned this pull request Sep 29, 2020
Merged
@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Oct 13, 2020

Close as already cherry-pick this change in PR #11525 and got merged. Thanks

@qiaozha qiaozha closed this Oct 13, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Dec 15, 2020
CodeGen from PR 11521 in Azure/azure-rest-api-specs
6f5654d 
add marketplaceordering config (Azure#11521)

* add marketplaceordering config

* fix config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozha qiaozha Awaiting requested review from qiaozha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diberry @qiaozha @ramya-rao-a