Identity project noUnusedParameters, noImplicitReturns and noUnusedLocals tsconfig fixes

sdk/identity/identity/review/identity.api.md

@@ -172,7 +172,7 @@ export class UsernamePasswordCredential implements TokenCredential {
 // @public
 export class VisualStudioCodeCredential implements TokenCredential {
     constructor(options?: VisualStudioCodeCredentialOptions);
-    getToken(scopes: string | string[], options?: GetTokenOptions): Promise<AccessToken | null>;
+    getToken(scopes: string | string[]): Promise<AccessToken | null>;
     }
 
 // @public

sdk/identity/identity/src/credentials/authorizationCodeCredential.browser.ts

@@ -3,7 +3,7 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { TokenCredential, GetTokenOptions, AccessToken } from "@azure/core-http";
+import { TokenCredential, AccessToken } from "@azure/core-http";
 import { TokenCredentialOptions } from "../client/identityClient";
 import { credentialLogger, formatError } from "../util/logging";
 
@@ -28,22 +28,12 @@ export class AuthorizationCodeCredential implements TokenCredential {
     redirectUri: string,
     options?: TokenCredentialOptions
   );
-  constructor(
-    tenantId: string | "common",
-    clientId: string,
-    clientSecretOrAuthorizationCode: string,
-    authorizationCodeOrRedirectUri: string,
-    redirectUriOrOptions: string | TokenCredentialOptions | undefined,
-    options?: TokenCredentialOptions
-  ) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  public getToken(
-    scopes: string | string[],
-    options?: GetTokenOptions
-  ): Promise<AccessToken | null> {
+  public getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/azureCliCredential.browser.ts

@@ -3,20 +3,19 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { AccessToken, TokenCredential, GetTokenOptions } from "@azure/core-http";
-import { TokenCredentialOptions } from "../client/identityClient";
+import { AccessToken, TokenCredential } from "@azure/core-http";
 import { credentialLogger, formatError } from "../util/logging";
 
 const BrowserNotSupportedError = new Error("AzureCliCredential is not supported in the browser.");
 const logger = credentialLogger("AzureCliCredential");
 
 export class AzureCliCredential implements TokenCredential {
-  constructor(options?: TokenCredentialOptions) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  getToken(scopes: string | string[], options?: GetTokenOptions): Promise<AccessToken | null> {
+  getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/azureCliCredential.ts

@@ -41,7 +41,7 @@ export class AzureCliCredential implements TokenCredential {
           `az account get-access-token --output json --resource ${resource}`,
           { cwd: getSafeWorkingDir() },
           (error, stdout, stderr) => {
-            resolve({ stdout: stdout, stderr: stderr });
+            resolve({ stdout: stdout, stderr: stderr, error });
           }
         );
       } catch (err) {

sdk/identity/identity/src/credentials/clientCertificateCredential.browser.ts

@@ -3,8 +3,7 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { TokenCredential, GetTokenOptions, AccessToken } from "@azure/core-http";
-import { TokenCredentialOptions } from "../client/identityClient";
+import { TokenCredential, AccessToken } from "@azure/core-http";
 import { credentialLogger, formatError } from "../util/logging";
 
 const BrowserNotSupportedError = new Error(
@@ -13,20 +12,12 @@ const BrowserNotSupportedError = new Error(
 const logger = credentialLogger("ClientCertificateCredential");
 
 export class ClientCertificateCredential implements TokenCredential {
-  constructor(
-    tenantId: string,
-    clientId: string,
-    certificatePath: string,
-    options?: TokenCredentialOptions
-  ) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  public getToken(
-    scopes: string | string[],
-    options?: GetTokenOptions
-  ): Promise<AccessToken | null> {
+  public getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/deviceCodeCredential.browser.ts

@@ -3,29 +3,19 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { TokenCredential, GetTokenOptions, AccessToken } from "@azure/core-http";
-import { DeviceCodePromptCallback } from "./deviceCodeCredential";
-import { TokenCredentialOptions } from "../client/identityClient";
+import { TokenCredential, AccessToken } from "@azure/core-http";
 import { credentialLogger, formatError } from "../util/logging";
 
 const BrowserNotSupportedError = new Error("DeviceCodeCredential is not supported in the browser.");
 const logger = credentialLogger("DeviceCodeCredential");
 
 export class DeviceCodeCredential implements TokenCredential {
-  constructor(
-    tenantId: string | "organizations",
-    clientId: string,
-    userPromptCallback: DeviceCodePromptCallback,
-    options?: TokenCredentialOptions
-  ) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  public getToken(
-    scopes: string | string[],
-    options?: GetTokenOptions
-  ): Promise<AccessToken | null> {
+  public getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/deviceCodeCredential.ts

@@ -1,10 +1,10 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-import { AccessToken, TokenCredential, GetTokenOptions, delay } from "@azure/core-http";
-import { TokenCredentialOptions, IdentityClient } from "../client/identityClient";
+import { AccessToken, TokenCredential, GetTokenOptions } from "@azure/core-http";
+import { TokenCredentialOptions } from "../client/identityClient";
 import { createSpan } from "../util/tracing";
-import { credentialLogger, formatSuccess } from "../util/logging";
-import { AuthenticationError, AuthenticationErrorName } from "../client/errors";
+import { credentialLogger } from "../util/logging";
+import { AuthenticationErrorName } from "../client/errors";
 import { CanonicalCode } from "@opentelemetry/api";
 
 import { PublicClientApplication, DeviceCodeRequest } from "@azure/msal-node";
@@ -55,7 +55,6 @@ export function defaultDeviceCodePromptCallback(deviceCodeInfo: DeviceCodeInfo):
  * that the user can enter into https://microsoft.com/devicelogin.
  */
 export class DeviceCodeCredential implements TokenCredential {
-  private identityClient: IdentityClient;
   private pca: PublicClientApplication;
   private tenantId: string;
   private clientId: string;
@@ -79,7 +78,6 @@ export class DeviceCodeCredential implements TokenCredential {
     userPromptCallback: DeviceCodePromptCallback = defaultDeviceCodePromptCallback,
     options?: TokenCredentialOptions
   ) {
-    this.identityClient = new IdentityClient(options);
     this.tenantId = tenantId;
     this.clientId = clientId;
     this.userPromptCallback = userPromptCallback;
@@ -117,7 +115,7 @@ export class DeviceCodeCredential implements TokenCredential {
    *                TokenCredential implementation might make.
    */
   getToken(scopes: string | string[], options?: GetTokenOptions): Promise<AccessToken | null> {
-    const { span, options: newOptions } = createSpan("DeviceCodeCredential-getToken", options);
+    const { span } = createSpan("DeviceCodeCredential-getToken", options);
 
     const scopeArray = typeof scopes === "object" ? scopes : [scopes];
 

sdk/identity/identity/src/credentials/environmentCredential.browser.ts

@@ -3,8 +3,7 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { AccessToken, TokenCredential, GetTokenOptions } from "@azure/core-http";
-import { TokenCredentialOptions } from "../client/identityClient";
+import { AccessToken, TokenCredential } from "@azure/core-http";
 import { credentialLogger, formatError } from "../util/logging";
 
 const BrowserNotSupportedError = new Error(
@@ -13,12 +12,12 @@ const BrowserNotSupportedError = new Error(
 const logger = credentialLogger("EnvironmentCredential");
 
 export class EnvironmentCredential implements TokenCredential {
-  constructor(options?: TokenCredentialOptions) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  getToken(scopes: string | string[], options?: GetTokenOptions): Promise<AccessToken | null> {
+  getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/interactiveBrowserCredential.ts

@@ -3,10 +3,9 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { TokenCredential, GetTokenOptions, AccessToken } from "@azure/core-http";
+import { TokenCredential, AccessToken, GetTokenOptions } from "@azure/core-http";
 import { InteractiveBrowserCredentialOptions } from "./interactiveBrowserCredentialOptions";
-import { credentialLogger, formatError } from "../util/logging";
-import { TokenCredentialOptions, IdentityClient } from "../client/identityClient";
+import { credentialLogger } from "../util/logging";
 import { DefaultTenantId, DeveloperSignOnClientId } from "../constants";
 import { Socket } from "net";
 
@@ -15,46 +14,30 @@ const SERVER_PORT = process.env.PORT || 80;
 import express from "express";
 import { PublicClientApplication, TokenCache, AuthorizationCodeRequest } from "@azure/msal-node";
 import open from "open";
-import path from "path";
 import http from "http";
 
-const BrowserNotSupportedError = new Error(
-  "InteractiveBrowserCredential is not supported in Node.js."
-);
 const logger = credentialLogger("InteractiveBrowserCredential");
 
-interface AuthenticationRecord {
-  authority?: string;
-  homeAccountId: string;
-  environment: string;
-  tenantId: string;
-  username: string;
-}
-
 /**
  * Enables authentication to Azure Active Directory inside of the web browser
  * using the interactive login flow, either via browser redirects or a popup
  * window.  This credential is not currently supported in Node.js.
  */
 export class InteractiveBrowserCredential implements TokenCredential {
-  private identityClient: IdentityClient;
   private pca: PublicClientApplication;
   private msalCacheManager: TokenCache;
   private tenantId: string;
   private clientId: string;
   private persistenceEnabled: boolean;
   private redirectUri: string;
   private authorityHost: string;
-  private authenticationRecord: AuthenticationRecord | undefined;
 
   constructor(options?: InteractiveBrowserCredentialOptions) {
-    this.identityClient = new IdentityClient(options);
     this.tenantId = (options && options.tenantId) || DefaultTenantId;
     this.clientId = (options && options.clientId) || DeveloperSignOnClientId;
 
     // Future update: this is for persistent caching
     this.persistenceEnabled = false;
-    this.authenticationRecord = undefined;
 
     if (options && options.redirectUri) {
       if (typeof options.redirectUri === "string") {
@@ -100,6 +83,7 @@ export class InteractiveBrowserCredential implements TokenCredential {
    */
   public getToken(
     scopes: string | string[],
+    //@ts-ignore
     options?: GetTokenOptions
   ): Promise<AccessToken | null> {
     const scopeArray = typeof scopes === "object" ? scopes : [scopes];

sdk/identity/identity/src/credentials/managedIdentityCredential.browser.ts

@@ -3,7 +3,7 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { AccessToken, GetTokenOptions, TokenCredential } from "@azure/core-http";
+import { AccessToken, TokenCredential } from "@azure/core-http";
 import { TokenCredentialOptions } from "../client/identityClient";
 import { credentialLogger, formatError } from "../util/logging";
 
@@ -15,18 +15,12 @@ const logger = credentialLogger("ManagedIdentityCredential");
 export class ManagedIdentityCredential implements TokenCredential {
   constructor(clientId: string, options?: TokenCredentialOptions);
   constructor(options?: TokenCredentialOptions);
-  constructor(
-    clientIdOrOptions: string | TokenCredentialOptions | undefined,
-    options?: TokenCredentialOptions
-  ) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  public async getToken(
-    scopes: string | string[],
-    options?: GetTokenOptions
-  ): Promise<AccessToken | null> {
+  public async getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/visualStudioCodeCredential.browser.ts

@@ -3,8 +3,7 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { TokenCredential, GetTokenOptions, AccessToken } from "@azure/core-http";
-import { TokenCredentialOptions } from "../client/identityClient";
+import { TokenCredential, AccessToken } from "@azure/core-http";
 import { credentialLogger, formatError } from "../util/logging";
 
 const BrowserNotSupportedError = new Error(
@@ -13,15 +12,12 @@ const BrowserNotSupportedError = new Error(
 const logger = credentialLogger("VisualStudioCodeCredential");
 
 export class VisualStudioCodeCredential implements TokenCredential {
-  constructor(options?: TokenCredentialOptions) {
+  constructor() {
     logger.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }
 
-  public getToken(
-    scopes: string | string[],
-    options?: GetTokenOptions
-  ): Promise<AccessToken | null> {
+  public getToken(): Promise<AccessToken | null> {
     logger.getToken.info(formatError(BrowserNotSupportedError));
     throw BrowserNotSupportedError;
   }

sdk/identity/identity/src/credentials/visualStudioCodeCredential.ts

@@ -3,7 +3,7 @@
 
 /* eslint-disable @typescript-eslint/no-unused-vars */
 
-import { TokenCredential, GetTokenOptions, AccessToken } from "@azure/core-http";
+import { TokenCredential, AccessToken } from "@azure/core-http";
 import { TokenCredentialOptions, IdentityClient } from "../client/identityClient";
 import fs from "fs";
 import os from "os";
@@ -140,10 +140,7 @@ export class VisualStudioCodeCredential implements TokenCredential {
    * @param options The options used to configure any requests this
    *                `TokenCredential` implementation might make.
    */
-  public async getToken(
-    scopes: string | string[],
-    options?: GetTokenOptions
-  ): Promise<AccessToken | null> {
+  public async getToken(scopes: string | string[]): Promise<AccessToken | null> {
     await this.prepareOnce();
     if (!keytar) {
       throw new CredentialUnavailable(

sdk/identity/identity/test/internal/identityClient.spec.ts

@@ -105,6 +105,8 @@ describe("IdentityClient", function() {
     assert(new IdentityClient({ authorityHost: "https://correct.url" }));
 
     delete process.env.AZURE_AUTHORITY_HOST;
+
+    return;
   });
 
   it("returns a usable error when the authentication response doesn't contain a body", async () => {

sdk/identity/identity/tsconfig.json

@@ -6,9 +6,9 @@
     "declarationDir": "./types",
     "outDir": "./dist-esm",
     "resolveJsonModule": true,
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
-    "noImplicitReturns": false
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noImplicitReturns": true
   },
   "include": ["src/**/*", "test/**/*"],
   "exclude": ["test/manual*/**/*", "node_modules"]