-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @opentelemetry/api to latest version #10393
Conversation
@markwolff FYI |
Nice! I think the rush exception can be removed now too
|
@markwolff There was a build error with |
Removed the rush exception in c56b4ad |
"@azure/logger": "^1.0.0", | ||
"@opentelemetry/api": "^0.6.1", | ||
"@opentelemetry/api": "^0.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides "change compile target to es5", is there any other changes involved and could influence end user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremymeng: You want to look at all breaking changes between 0.6.1
and 0.10.2
, not just the changes in the 0.10.2
release. I personally do not know if or how any of these breaking changes might impact our packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately we use very little of their public surface area and active development has been in other areas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that's right I was only looking at last release. But Jeff knows more!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all the release notes from 0.6.1
-- there were breaking changes in metrics (which we don't use yet), but not tracing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with both storage-blob and search-documents and it worked flawlessly.
This PR updates the version for
"@opentelemetry/api"
to 0.10.2 to take in the fix open-telemetry/opentelemetry-js#1368 that fixes open-telemetry/opentelemetry-js#902which in turn fixes #9702