[Test Recorder] Fix an issue where not all browser requests are recorded

sdk/appconfiguration/app-configuration/test/auth.spec.ts

@@ -15,8 +15,8 @@ describe("Authentication", () => {
     credsAndEndpoint = getTokenAuthenticationCredential() || this.skip();
   });
 
-  afterEach(function() {
-    recorder.stop();
+  afterEach(async function() {
+    await recorder.stop();
   });
 
   it("invalid connection string gives a decent error message", () => {

sdk/appconfiguration/app-configuration/test/etags.spec.ts

@@ -28,7 +28,7 @@ describe("etags", () => {
 
   afterEach(async function() {
     await deleteKeyCompletely([key], client);
-    recorder.stop();
+    await recorder.stop();
   });
 
   // etag usage is 'opt-in' via the onlyIfChanged/onlyIfUnchanged options for certain calls

sdk/appconfiguration/app-configuration/test/index.readonlytests.spec.ts

@@ -28,7 +28,7 @@ describe("AppConfigurationClient (set|clear)ReadOnly", () => {
 
   afterEach(async function() {
     await deleteKeyCompletely([testConfigSetting.key], client);
-    recorder.stop();
+    await recorder.stop();
   });
 
   it("basic", async function() {

sdk/appconfiguration/app-configuration/test/index.spec.ts

@@ -24,8 +24,8 @@ describe("AppConfigurationClient", () => {
     client = createAppConfigurationClientForTests() || this.skip();
   });
 
-  afterEach(function() {
-    recorder.stop();
+  afterEach(async function() {
+    await recorder.stop();
   });
 
   describe("simple usages", () => {

sdk/appconfiguration/app-configuration/test/internal/http.spec.ts

@@ -108,8 +108,8 @@ describe("http request related tests", function() {
       client = createAppConfigurationClientForTests() || this.skip();
     });
 
-    afterEach(function() {
-      recorder.stop();
+    afterEach(async function() {
+      await recorder.stop();
     });
 
     it("custom client request ID", async () => {

sdk/appconfiguration/app-configuration/test/throwOrNotThrow.spec.ts

@@ -22,8 +22,8 @@ describe("Various error cases", () => {
     client = createAppConfigurationClientForTests() || this.skip();
   });
 
-  afterEach(function() {
-    recorder.stop();
+  afterEach(async function() {
+    await recorder.stop();
   });
 
   describe("throws", () => {

sdk/formrecognizer/ai-form-recognizer/test/browser/formrecognizerclient.spec.ts

@@ -16,9 +16,9 @@ describe("FormRecognizerClient browser only", () => {
     ({ recorder, client } = createRecordedRecognizerClient(this, apiKey));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 

sdk/formrecognizer/ai-form-recognizer/test/browser/formtrainingclient.spec.ts

@@ -33,9 +33,9 @@ describe("FormTrainingClient browser only", () => {
     );
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 
@@ -214,9 +214,9 @@ describe("FormRecognizerClient custom form recognition browser only", () => {
     ({ recorder, client: recognizerClient } = createRecordedRecognizerClient(this, apiKey));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
   it("recognizes form url unlabeled model", async () => {

sdk/formrecognizer/ai-form-recognizer/test/node/formrecognizerclient.spec.ts

@@ -19,9 +19,9 @@ describe("FormRecognizerClient NodeJS only", () => {
     ({ recorder, client } = createRecordedRecognizerClient(this, apiKey));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 
@@ -157,9 +157,9 @@ describe("[AAD] FormRecognizerClient NodeJS only", () => {
     ({ recorder, client } = createRecordedRecognizerClient(this));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 

sdk/formrecognizer/ai-form-recognizer/test/node/formtrainingclient.spec.ts

@@ -35,9 +35,9 @@ describe("FormTrainingClient NodeJS only", () => {
     ({ recorder, client: trainingClient } = createRecordedTrainingClient(this, apiKey));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 
@@ -237,9 +237,9 @@ describe("FormRecognizerClient form recognition NodeJS", () => {
     ({ recorder, client: recognizerClient } = createRecordedRecognizerClient(this, apiKey));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 
@@ -396,9 +396,9 @@ describe("[AAD] FormTrainingClient NodeJS only", () => {
     ({ recorder, client: trainingClient } = createRecordedTrainingClient(this));
   });
 
-  afterEach(function() {
+  afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
   });
 

sdk/keyvault/keyvault-certificates/test/internal/challengeBasedAuthenticationPolicy.spec.ts

@@ -41,7 +41,7 @@ describe("Challenge based authentication tests", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/CRUD.spec.ts

@@ -44,7 +44,7 @@ describe("Certificates client - create, read, update and delete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/list.spec.ts

@@ -35,7 +35,7 @@ describe("Certificates client - list certificates in various ways", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/lro.create.spec.ts

@@ -26,7 +26,7 @@ describe("Certificates client - LRO - create", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/lro.delete.spec.ts

@@ -26,7 +26,7 @@ describe("Certificates client - lro - delete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/lro.operation.spec.ts

@@ -30,7 +30,7 @@ describe("Certificates client - LRO - certificate operation", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/lro.recover.spec.ts

@@ -27,7 +27,7 @@ describe("Certificates client - LRO - recoverDelete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/mergeAndImport.spec.ts

@@ -36,7 +36,7 @@ describe("Certificates client - merge and import certificates", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-certificates/test/public/recoverBackupRestore.spec.ts

@@ -32,7 +32,7 @@ describe("Certificates client - restore certificates and recover backups", () =>
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/internal/challengeBasedAuthenticationPolicy.spec.ts

@@ -35,7 +35,7 @@ describe("Challenge based authentication tests", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/public/CRUD.spec.ts

@@ -33,7 +33,7 @@ describe("Keys client - create, read, update and delete operations", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/public/crypto.spec.ts

@@ -45,7 +45,7 @@ describe("CryptographyClient (all decrypts happen remotely)", () => {
   afterEach(async function() {
     if (!this.currentTest?.isPending()) {
       await testClient.flushKey(keyName);
-      recorder.stop();
+      await recorder.stop();
     }
   });
 

sdk/keyvault/keyvault-keys/test/public/import.spec.ts

@@ -25,7 +25,7 @@ describe("Keys client - import keys", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/public/list.spec.ts

@@ -26,7 +26,7 @@ describe("Keys client - list keys in various ways", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/public/lro.delete.spec.ts

@@ -26,7 +26,7 @@ describe("Keys client - Long Running Operations - delete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/public/lro.recoverDelete.spec.ts

@@ -27,7 +27,7 @@ describe("Keys client - Long Running Operations - recoverDelete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-keys/test/public/recoverBackupRestore.spec.ts

@@ -27,7 +27,7 @@ describe("Keys client - restore keys and recover backups", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-secrets/test/internal/challengeBasedAuthenticationPolicy.spec.ts

@@ -35,7 +35,7 @@ describe("Challenge based authentication tests", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-secrets/test/public/CRUD.spec.ts

@@ -28,7 +28,7 @@ describe("Secret client - create, read, update and delete operations", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-secrets/test/public/list.spec.ts

@@ -30,7 +30,7 @@ describe("Secret client - list secrets in various ways", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-secrets/test/public/lro.delete.spec.ts

@@ -27,7 +27,7 @@ describe("Secrets client - Long Running Operations - delete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-secrets/test/public/lro.recover.spec.ts

@@ -27,7 +27,7 @@ describe("Secrets client - Long Running Operations - recoverDelete", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/keyvault/keyvault-secrets/test/public/recoverBackupRestore.spec.ts

@@ -27,7 +27,7 @@ describe("Secret client - restore secrets and recover backups", () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   // The tests follow

sdk/search/search-documents/test/node/searchIndexClient.spec.ts

@@ -34,7 +34,7 @@ describe("SearchClient", function() {
 
   afterEach(async function() {
     if (recorder) {
-      recorder.stop();
+      await recorder.stop();
     }
     if (!isPlaybackMode()) {
       await indexClient.deleteIndex(TEST_INDEX_NAME);

sdk/storage/storage-blob-changefeed/test/blobchangefeedclient.spec.ts

@@ -25,7 +25,7 @@ describe("BlobChangeFeedClient", async () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   it("next(): fetch all events", async () => {
@@ -129,7 +129,7 @@ describe("BlobChangeFeedClient: Change Feed not configured", async () => {
   });
 
   afterEach(async function() {
-    recorder.stop();
+    await recorder.stop();
   });
 
   it("should throw when fetching changes", async () => {