Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin NodeTestVersion of 21.2.0 #27957

Closed
jeremymeng opened this issue Dec 1, 2023 · 2 comments
Closed

Unpin NodeTestVersion of 21.2.0 #27957

jeremymeng opened this issue Dec 1, 2023 · 2 comments
Assignees
@jeremymeng

Comments

@jeremymeng
Copy link
Member

when the fs.writeFileSync regression is fixed in newer version.
@jeremymeng jeremymeng self-assigned this Dec 1, 2023
This was referenced Dec 1, 2023
Merged
Merged
jeremymeng added a commit that referenced this issue Dec 6, 2023
@jeremymeng
[EngSys] unpin NodeTestVersion of 21.2.0 (#27999)
884d750 
now that a fix to `fs.writeFileSync` has been released.

Revert "Temporarily pin NodeTestVersion of v21 to 21.2.0 (#27951)"

This reverts commit b1a31b3.

### Issues associated with this PR
#27957
@jeremymeng
Copy link
Member Author

done

@jeremymeng jeremymeng reopened this Dec 14, 2023
@jeremymeng
Copy link
Member Author

Need to pin again #28053

jeremymeng added a commit that referenced this issue Apr 30, 2024
@jeremymeng
[EngSys] Move from NodeJS v21 to v22
a281aaf 
Resolves issue #27957
@jeremymeng jeremymeng mentioned this issue Apr 30, 2024
Merged
jeremymeng added a commit that referenced this issue Apr 30, 2024
@jeremymeng
[EngSys] Move from NodeJS v21 to v22 (#29537)
b676a99 
Resolves issue #27957
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremymeng