Making databaseAccount read dynamic #7831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
added
Cosmos
cosmos:v4-item
simplynaveen20
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar and
moderakh
as code owners
simplynaveen20
commented
Jan 29, 2020
...va/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReader.java
Outdated
Show resolved
Hide resolved
moderakh
suggested changes
Jan 31, 2020
...va/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReader.java
Outdated
Show resolved
Hide resolved
...va/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReader.java
Outdated
Show resolved
Hide resolved
...om/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java
Outdated
Show resolved
Hide resolved
...om/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
This work done in #8466 |
simplynaveen20
deleted the
users/nakumar/makingDatabaseAccountConfigurationDynamic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently GatewayServiceConfigurationReader initialize during client start up with one time snapshot of databaseAccount read via GlobalEndPointManager. Its value remain same throughout the lifespan of application.
This PR will read all the databaseAccount configurations via GatewayServiceConfigurationReader dynamically from cache which updates with its scheduling mechanism or any read/write account error.
This will also fix an issue in which application hits DatabaseAccount read call twice during startup.
fixes #7668