Skip to content

Added response decoder configuration to fix max header size issue #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushagraThapar merged 1 commit into from
Jan 8, 2020
Merged

Added response decoder configuration to fix max header size issue #7249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...s/azure-cosmos/src/main/java/com/azure/cosmos/implementation/http/ReactorNettyClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.
package com.azure.cosmos.implementation.http;

import com.azure.cosmos.implementation.Configs;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import io.netty.channel.ChannelOption;
Expand Down Expand Up @@ -63,22 +64,29 @@ public static ReactorNettyClient createWithConnectionProvider(ConnectionProvider
}

private void configureChannelPipelineHandlers() {
Configs configs = this.httpClientConfig.getConfigs();
this.httpClient = this.httpClient.tcpConfiguration(tcpClient -> {

if (this.httpClientConfig.getProxy() != null) {
tcpClient =
tcpClient.proxy(typeSpec -> typeSpec.type(ProxyProvider.Proxy.HTTP).address(this.httpClientConfig.getProxy()));
}
tcpClient =
tcpClient.secure(sslContextSpec -> sslContextSpec.sslContext(this.httpClientConfig.getConfigs().getSslContext()));
tcpClient.secure(sslContextSpec -> sslContextSpec.sslContext(configs.getSslContext()));
if (LoggerFactory.getLogger(REACTOR_NETWORK_LOG_CATEGORY).isTraceEnabled()) {
tcpClient = tcpClient.wiretap(REACTOR_NETWORK_LOG_CATEGORY, LogLevel.INFO);
}
// By default, keep alive is enabled on http client
tcpClient = tcpClient.option(ChannelOption.CONNECT_TIMEOUT_MILLIS,
httpClientConfig.getConfigs().getConnectionAcquireTimeoutInMillis());
configs.getConnectionAcquireTimeoutInMillis());

return tcpClient;
}).httpResponseDecoder(httpResponseDecoderSpec -> {
httpResponseDecoderSpec.maxInitialLineLength(configs.getMaxHttpInitialLineLength());
httpResponseDecoderSpec.maxHeaderSize(configs.getMaxHttpHeaderSize());
httpResponseDecoderSpec.maxChunkSize(configs.getMaxHttpChunkSize());
httpResponseDecoderSpec.validateHeaders(true);
return httpResponseDecoderSpec;
});
}

Expand Down