Don't retry on network failure on writes #7243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
David-Noble-at-work,
kirankumarkolli and
moderakh
as code owners
Merged
moderakh
approved these changes
Jan 7, 2020
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
Looks good to me. As @simplynaveen20 has done some work on fail over retry. that would be great Naveen if you also take a look.
Member
Author
Yes, I made sure to take a look at DR fixes PR for v2 before porting this change. |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thank you Naveen for finding the bug. :-) |
moderakh
approved these changes
Jan 13, 2020
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct Port of Azure/azure-cosmosdb-java#301