-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for VM size #716
Merged
Merged
Support for VM size #716
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
...mgmt-compute/src/main/java/com/microsoft/azure/management/compute/VirtualMachineSize.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package com.microsoft.azure.management.compute; | ||
|
||
public interface VirtualMachineSize { | ||
/** | ||
* Gets the VM size name. | ||
*/ | ||
String name(); | ||
|
||
/** | ||
* Gets the Number of cores supported by a VM size. | ||
*/ | ||
Integer numberOfCores(); | ||
|
||
/** | ||
* Gets the OS disk size allowed by a VM size. | ||
*/ | ||
Integer osDiskSizeInMB(); | ||
|
||
/** | ||
* Gets Resource disk size allowed by a VM size. | ||
*/ | ||
Integer resourceDiskSizeInMB(); | ||
|
||
/** | ||
* Gets the Memory size supported by a VM size. | ||
*/ | ||
Integer memoryInMB(); | ||
|
||
/** | ||
* Gets or the Maximum number of data disks allowed by a VM size. | ||
*/ | ||
Integer maxDataDiskCount(); | ||
} |
23 changes: 22 additions & 1 deletion
23
azure-mgmt-compute/src/main/java/com/microsoft/azure/management/compute/VirtualMachines.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,42 @@ | ||
package com.microsoft.azure.management.compute; | ||
|
||
import com.microsoft.azure.CloudException; | ||
import com.microsoft.azure.PagedList; | ||
import com.microsoft.azure.management.resources.fluentcore.arm.collection.SupportsDeletingByGroup; | ||
import com.microsoft.azure.management.resources.fluentcore.arm.collection.SupportsGettingByGroup; | ||
import com.microsoft.azure.management.resources.fluentcore.arm.collection.SupportsListingByGroup; | ||
import com.microsoft.azure.management.resources.fluentcore.collection.SupportsCreating; | ||
import com.microsoft.azure.management.resources.fluentcore.collection.SupportsDeleting; | ||
import com.microsoft.azure.management.resources.fluentcore.collection.SupportsListing; | ||
|
||
import java.io.IOException; | ||
|
||
public interface VirtualMachines extends | ||
SupportsListing<VirtualMachine>, | ||
SupportsListingByGroup<VirtualMachine>, | ||
SupportsGettingByGroup<VirtualMachine>, | ||
SupportsCreating<VirtualMachine.DefinitionBlank>, | ||
SupportsDeleting, | ||
SupportsDeletingByGroup { | ||
/** | ||
* Lists all available virtual machine sizes in a region. | ||
* @param region The region upon which virtual-machine-sizes is queried. | ||
* @return the List<VirtualMachineSize> if successful. | ||
* @throws CloudException | ||
* @throws IOException | ||
*/ | ||
PagedList<VirtualMachineSize> listSizes(String region) throws CloudException, IOException; | ||
interface InGroup extends | ||
SupportsListing<VirtualMachine>, | ||
SupportsCreating<VirtualMachine.DefinitionBlank>, | ||
SupportsDeleting {} | ||
SupportsDeleting { | ||
/** | ||
* Lists all available virtual machine sizes in a region. | ||
* @param region The region upon which virtual-machine-sizes is queried. | ||
* @return the List<VirtualMachineSize> if successful. | ||
* @throws CloudException | ||
* @throws IOException | ||
*/ | ||
PagedList<VirtualMachineSize> listSizes(String region) throws CloudException, IOException; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
...in/java/com/microsoft/azure/management/compute/implementation/VirtualMachineSizeImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
package com.microsoft.azure.management.compute.implementation; | ||
|
||
import com.microsoft.azure.management.compute.VirtualMachineSize; | ||
import com.microsoft.azure.management.compute.implementation.api.VirtualMachineSizeInner; | ||
|
||
public class VirtualMachineSizeImpl implements VirtualMachineSize { | ||
private VirtualMachineSizeInner innerModel; | ||
|
||
public VirtualMachineSizeImpl(VirtualMachineSizeInner innerModel) { | ||
this.innerModel = innerModel; | ||
} | ||
|
||
@Override | ||
public String name() { | ||
return innerModel.name(); | ||
} | ||
|
||
@Override | ||
public Integer numberOfCores() { | ||
return innerModel.numberOfCores(); | ||
} | ||
|
||
@Override | ||
public Integer osDiskSizeInMB() { | ||
return innerModel.osDiskSizeInMB(); | ||
} | ||
|
||
@Override | ||
public Integer resourceDiskSizeInMB() { | ||
return innerModel.resourceDiskSizeInMB(); | ||
} | ||
|
||
@Override | ||
public Integer memoryInMB() { | ||
return innerModel.memoryInMB(); | ||
} | ||
|
||
@Override | ||
public Integer maxDataDiskCount() { | ||
return innerModel.maxDataDiskCount(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the 'withSize(..)' setters are optional and default to "Basic_A0".
In portal this is something user needs to explicitly specify, so we need to decide whether to make it required or optional for user.