Skip to content

Use standard scheduler and dispose of Integration test one #7127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
conniey merged 2 commits into from
Jan 6, 2020
Merged

Use standard scheduler and dispose of Integration test one #7127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3789295
Use standard scheduler and dispose of it.
conniey Jan 5, 2020
faf6007
Using elastic scheduler.
conniey Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...samples/java/com/azure/messaging/eventhubs/EventProcessorClientAggregateEventsSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public static void main(String[] args) throws Exception {
*/
private static Mono<Void> generateEvents(AtomicBoolean isRunning) {
final Logger logger = LoggerFactory.getLogger("Producer");
final Scheduler scheduler = Schedulers.newElastic("produce");
final Scheduler scheduler = Schedulers.elastic();
final Duration operationTimeout = Duration.ofSeconds(5);
final String[] machineIds = new String[]{"2A", "9B", "6C"};
final Random random = new Random();
Expand Down Expand Up @@ -129,10 +129,11 @@ private static Mono<Void> generateEvents(AtomicBoolean isRunning) {
return client.send(batch);
}).block(operationTimeout);
}
}).doFinally(signal -> {
logger.info("Disposing of producer.");
client.close();
}).subscribeOn(scheduler);
}).subscribeOn(scheduler)
Copy link
Member

@srnagar srnagar Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the order of subscribeOn() matter?

Copy link
Member Author

@conniey conniey Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this, order doesn't matter.
https://stackoverflow.com/a/37986481/4220757

.doFinally(signal -> {
logger.info("Disposing of producer.");
client.close();
});
}
}

Expand Down