draft to update contributing for updated versioning #7093
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
|
|
||
| # This script requires Powershell 6 which defaults LocalMachine to Restricted on Windows client machines. | ||
| # From a Powershell 6 prompt run 'Get-ExecutionPolicy -List' and if the LocalMachine is Restricted or Undefined then | ||
| # run the following command from an admin Powershell 6 prompt 'Set-ExecutionPolicy -ExecutionPolicy RemoteSigned'. This | ||
| # will enable running scripts locally in Powershell 6. | ||
|
|
||
|
|
||
| # Use case: This script verifies the following: | ||
| # 1. There are no duplicate entries in any of the version_*.txt files | ||
| # 2. There are no duplicate entries in the external_dependencies.txt file | ||
|
|
@@ -288,7 +293,7 @@ Get-ChildItem -Path $Path -Filter pom*.xml -Recurse -File | ForEach-Object { | |
| if ($retVal) | ||
| { | ||
| $script:FoundError = $true | ||
| Write-Error-With-Color "$($retVal)" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -332,7 +337,7 @@ Get-ChildItem -Path $Path -Filter pom*.xml -Recurse -File | ForEach-Object { | |
| if ($retVal) | ||
| { | ||
| $script:FoundError = $true | ||
| Write-Error-With-Color "$($retVal)" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -427,7 +432,7 @@ Get-ChildItem -Path $Path -Filter pom*.xml -Recurse -File | ForEach-Object { | |
| if ($retVal) | ||
| { | ||
| $script:FoundError = $true | ||
| Write-Error-With-Color "$($retVal)" | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -444,8 +449,8 @@ Write-Host "Total run time=$($TotalRunTime)" | |
|
|
||
| if ($script:FoundError) | ||
| { | ||
| Write-Error-With-Color "There were errors encountered during execution. Please fix any errors and run the script again." | ||
| Write-Error-With-Color "This script can be run locally from the root of the repo. .\eng\pom_file_version_scanner.ps1" | ||
|
Contributor
There was a problem hiding this comment. Could we add line telling user that, it needs to be run in powershell. Also it need certain permission in powershell, I had issues running it yesterday . How to set permission in PS https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-executionpolicy?view=powershell-6
Contributor
Author
There was a problem hiding this comment. I can add something to the description at the top of the file for local setup. The images doing the building already have the correct permissions in place. I don't think I need to tell them that it needs to be run in powershell considering the extension is .ps1 which is the powershell extension. |
||
| exit(1) | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we automate this by checking if
unreleased_version is in available in maven -> break the build and it will force developer to remove "unreleased_" . May be create a separate ticket for this ?May be I am asking too much. Ignore it if you feel it is unnecessory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best we're going to get here is to verify that you're not trying to release something with "unreleaed_" dependencies. There's already a work item for that #6184 (it's a two part work item, I've already got the first part completed).