AsyncReadBenchmark should use v4 API e2e #6683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moderakh
requested review from
David-Noble-at-work,
kirankumarkolli and
kushagraThapar
as code owners
moderakh
changed the title
kushagraThapar
requested changes
Dec 6, 2019
sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/BridgeInternalBenchmark.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncBenchmark.java
Outdated
Show resolved
Hide resolved
...smos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncReadBenchmark.java
Show resolved
Hide resolved
kushagraThapar
approved these changes
Dec 6, 2019
...smos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncReadBenchmark.java
Show resolved
Hide resolved
Contributor
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our benchmark tool has been wired up against the internal API of
AsyncDocumentClient.readDocument(.)rather than the v4 APIcosmosContainer.getItem().read(). Therefore the benchmark tool doesn't provide the true end 2 end perf numbers.This PR changes AsyncReadBenchmark to use v4 API e2e (i.e,
cosmosContainer.getItem().read()) to provide a correct perf number of read throughput e2e