Skip to content

Run live tests on all operating systems #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimSuplizio merged 9 commits into from
Dec 11, 2019
Merged

Run live tests on all operating systems #6668

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0e097ff
live tests for all OS
JimSuplizio Dec 5, 2019
2581c82
Use values from global for Maven options
JimSuplizio Dec 5, 2019
a38380d
Changes for Cosmos
JimSuplizio Dec 9, 2019
7d064d5
Correctly set the DisplayName
JimSuplizio Dec 10, 2019
244e412
set DisplayName part 2
JimSuplizio Dec 10, 2019
4b8e3ab
adjust spacing in yml
JimSuplizio Dec 10, 2019
589cbb7
set display name
JimSuplizio Dec 10, 2019
c5ba2b8
Remove the setting of display name to empty
JimSuplizio Dec 10, 2019
14cb535
Merge branch 'master' into LiveTestsOnAllOS
JimSuplizio Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions eng/pipelines/templates/jobs/archetype-sdk-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,44 @@
parameters:
DisplayName: ''
ServiceDirectory: ''
EnvVars: {}
MaxParallel: 0
Matrix:
Win2016:
Linux - Java 8:
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
JavaVersion: '1.8'
macOS - Java 8:
OSName: 'macOS'
OSVmImage: 'macOS-10.13'
JavaVersion: '1.8'
Windows - Java 8:
OSName: 'Windows'
OSVmImage: 'windows-2019'
DisplayName: 'Run Live tests'
JavaVersion: '1.8'
Linux - Java 11:
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
JavaVersion: '1.11'
macOS - Java 11:
OSName: 'macOS'
OSVmImage: 'macOS-10.13'
JavaVersion: '1.11'
Windows - Java 11:
OSName: 'Windows'
OSVmImage: 'windows-2019'
JavaVersion: '1.11'
PreRunSteps: []
TestName: LiveTest
TimeoutInMinutes: 60
TestStepMavenInputs:
Copy link
Member

@danieljurek danieljurek Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk/cosmos/tests.yml uses TestStepMavenInputs right now because its goal is verify instead of test. Seems like this could be standardized to test or something like it.

The cosmos live tests also use options specified in the matrix https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/cosmos/tests.yml#L54 ... these are used to configure the test scenarios. However, I wonder if we can append the DefaultOptions from https://github.com/Azure/azure-sdk-for-java/blob/master/eng/pipelines/templates/variables/globals.yml#L2 (though this is probably less important)

Until the cosmos tests can be made more uniform with our specs we should keep TestStepMavenInputs as a parameter.

@kushagraThapar -- what's needed to switch the goal from verify to test and would there be any drawbacks to appending our DefaultOptions to the maven options?

options: '--batch-mode --fail-at-end -Dmaven.wagon.http.pool=false -Dsurefire.rerunFailingTestsCount=3 --settings eng/settings.xml'
mavenOptions: '-Xmx3072m -Dorg.slf4j.simpleLogger.defaultLogLevel=error -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'
options: '-Dmaven.wagon.http.pool=false -Dsurefire.rerunFailingTestsCount=3 $(DefaultOptions)'
mavenOptions: '$(MemoryOptions) $(LoggingOptions)'
javaHomeOption: 'JDKVersion'
jdkVersionOption: '1.8'
jdkVersionOption: '$(JavaVersion)'
jdkArchitectureOption: 'x64'
publishJUnitResults: false
goals: 'test'
goals: 'test'
TestResultsFiles: ''

jobs:
Expand All @@ -33,6 +55,11 @@ jobs:
vmImage: $(OSVmImage)

steps:
- script: |
echo "##vso[task.setvariable variable=DisplayName]$(OSName) on Java $(JavaVersion)"
displayName: "Setup DisplayName"
condition: eq(variables['DisplayName'], '')

- ${{ parameters.PreRunSteps }}

- task: Maven@3
Expand Down