-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Run live tests on all operating systems #6668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e097ff
live tests for all OS
JimSuplizio 2581c82
Use values from global for Maven options
JimSuplizio a38380d
Changes for Cosmos
JimSuplizio 7d064d5
Correctly set the DisplayName
JimSuplizio 244e412
set DisplayName part 2
JimSuplizio 4b8e3ab
adjust spacing in yml
JimSuplizio 589cbb7
set display name
JimSuplizio c5ba2b8
Remove the setting of display name to empty
JimSuplizio 14cb535
Merge branch 'master' into LiveTestsOnAllOS
JimSuplizio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdk/cosmos/tests.ymlusesTestStepMavenInputsright now because its goal isverifyinstead oftest. Seems like this could be standardized totestor something like it.The cosmos live tests also use options specified in the matrix https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/cosmos/tests.yml#L54 ... these are used to configure the test scenarios. However, I wonder if we can append the
DefaultOptionsfrom https://github.com/Azure/azure-sdk-for-java/blob/master/eng/pipelines/templates/variables/globals.yml#L2 (though this is probably less important)Until the cosmos tests can be made more uniform with our specs we should keep
TestStepMavenInputsas a parameter.@kushagraThapar -- what's needed to switch the goal from
verifytotestand would there be any drawbacks to appending ourDefaultOptionsto the maven options?