Skip to content

Profile activation for verify readme #6650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srnagar merged 6 commits into from
Dec 5, 2019
Merged

Profile activation for verify readme #6650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9602f4
Add maven profile to verify readme
srnagar Dec 4, 2019
9aeb299
Revert changes to readme to pass the CI pipeline
srnagar Dec 4, 2019
a14161b
Separate profiles for Windows
srnagar Dec 4, 2019
d26aa29
Profile activation for verify readme
srnagar Dec 5, 2019
50490f6
Resolve merge conflicts
srnagar Dec 5, 2019
472a888
Revert test changes
srnagar Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
- pwsh: |
$(Build.SourcesDirectory)/eng/versioning/pom_file_version_scanner.ps1
displayName: "Verify versions in POM files"

- task: UsePythonVersion@0
displayName: 'Use Python 3.6'
inputs:
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
displayName: 'Install all client libraries (for SpotBugs analysis)'
inputs:
mavenPomFile: pom.client.xml
options: '$(DefaultOptions) -DskipTests -Dgpg.skip -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true'
options: '$(DefaultOptions) -DskipTests -Dgpg.skip -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true -Dverify-readme'
mavenOptions: '$(MemoryOptions) $(LoggingOptions)'
javaHomeOption: 'JDKVersion'
jdkVersionOption: '1.11'
Expand Down
12 changes: 6 additions & 6 deletions pom.client.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,9 +1048,9 @@
<!-- separate profile for windows as the executable on windows is named npx.cmd and npx on other os families -->
<id>verify-readme-windows</id>
<activation>
<os>
<family>windows</family>
</os>
<property>
<name>verify-readme-windows</name>
Copy link
Member

@weshaggard weshaggard Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my information what does this readme verification tool do?

</property>
</activation>
<build>
<plugins>
Expand Down Expand Up @@ -1085,9 +1085,9 @@
<profile>
<id>verify-readme</id>
<activation>
<os>
<family>!windows</family>
</os>
<property>
<name>verify-readme</name>
</property>
</activation>
<build>
<plugins>
Expand Down