Skip to content

Fixing checkstyle issues #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbhaskar merged 12 commits into from
Dec 13, 2019
Merged

Fixing checkstyle issues #6643

mbhaskar merged 12 commits into from
Dec 13, 2019

Conversation

@mbhaskar
Copy link
Member

@mbhaskar mbhaskar commented Dec 4, 2019 •
edited
Loading

  • Fixing checkstyle issues in cosmos package
  • Donot contain fixes for benchmark and examples
  • Added excludes for implementation and tests packages and BridgeInternal and CosmosBridgeInternal classes in pom
  • Changed logger from sl4j logger to azure.core.util.logging.ClientLogger in JsonSerializable

Public surface changes

  • Renamed the method builder() in CosmosClient and CosmosAsyncClient to cosmosClientBuilder()
  • Renamed PartitionKey.None to ParitionKey.NONE

New codesnippet model –
Going forward for any multiple line, substantial code documentation please follow the way I used in IndexPolicyCodeSnippet, it will avoid any outdated code in the documentation

==
Reverted logger and exception checkstyle recommendations and disabled checkstyle failOnError for now. Will have to reenable after fixing the above

mbhaskar and others added 5 commits November 20, 2019 12:05
@mbhaskar
checkstyle changes
43b2bfe
@simplynaveen20
fixing check style fixes
b3f697e
@mbhaskar
Renaming builders
9eafc99
@mbhaskar
Merge branch 'feature/cosmos/upstream-v4' into mbhaskar/v4-checkstyle…
932a019 
…-changes

# Conflicts:
#	sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/BasicDemo.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ConflictResolutionMode.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ConflictResolutionPolicy.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosContainer.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosItemProperties.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/JsonSerializable.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentQueryExecutionContextFactory.java
#	sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosPartitionKeyTests.java
@mbhaskar
Fixing checkstyle issues
c72f0bf
moderakh
moderakh suggested changes Dec 4, 2019
View reviewed changes
@mbhaskar mbhaskar added the Cosmos label Dec 9, 2019
@mbhaskar
Fixing failing unit tests
97d7e7e 
Removing throwing check exceptions from sync wrapper
moderakh
moderakh suggested changes Dec 11, 2019
View reviewed changes
@mbhaskar
Merge branch 'feature/cosmos/upstream-v4' into mbhaskar/v4-checkstyle…
3df1b8c 
…-changes

# Conflicts:
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientSideRequestStatistics.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientException.java
#	sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/InternalServerErrorException.java
@mbhaskar
Reverting the change that moves CosmosClientException to RuntimeExcep…
2b38224 
…tion

Moving back to Slf4j logger from azure core logger
Moving back checkstyle fails to false. This has to enabled after
deciding on the logger
@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 12, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@moderakh moderakh self-requested a review December 12, 2019 07:03
moderakh
moderakh approved these changes Dec 12, 2019
View reviewed changes
kushagraThapar
kushagraThapar requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions. Please review them.

@mbhaskar
- Removing excludes list from checkstyle. This can be added later when
a66e948 
enabling checkstyle violations in the right place (eng/exceptions)
- Implementing PR comments
@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 12, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Member Author

mbhaskar commented Dec 12, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar mbhaskar merged commit c295e4d into Azure:feature/cosmos/v4 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@David-Noble-at-work David-Noble-at-work Awaiting requested review from David-Noble-at-work

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

+1 more reviewer

@moderakh moderakh moderakh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Cosmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbhaskar @kushagraThapar @moderakh @simplynaveen20