Add Iterable<T> overload for IterableStream<T> #6534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
added
Client
JonathanGiles
approved these changes
Nov 25, 2019
srnagar
reviewed
Nov 25, 2019
| * @throws NullPointerException if {@code iterable} is {@code null}. | ||
| */ | ||
| public IterableStream(Iterable<T> iterable) { | ||
| this.iterable = Objects.requireNonNull(iterable, "'iterable' cannot be null."); |
Member
There was a problem hiding this comment.
Instead of having flux and iterable fields in this class, if an instance of IterableStream is created using an iterable, can this just be converted to this.flux = Flux.fromIterable(Objects.requireNonNull(iterable, "'iterable' cannot be null."));. Simplifies code in other methods too where you don't have to check if flux is null or iterable is null.
Member
Author
There was a problem hiding this comment.
Unfortunately this will result in that illegal state exception again because we are moving from sync to async world then back again.
It was what the code was doing before this overload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6515 and reactor/reactor-core#1972