[Event Hubs] Replace constant strings with resource strings #3923 #6529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mclay
commented
Nov 24, 2019
mclay
commented
- proposal implementation for azure-messaging-eventhubs
- proposal implementation for azure-messaging-eventhubs
mclay
requested review from
JonathanGiles,
conniey,
mssfang and
srnagar
as code owners
Contributor
|
Can one of the admins verify this patch? |
added 2 commits
November 24, 2019 20:43
- migrate unit tests in sdk/storage/*
- checkstyle fix
...venthubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/Messages.java
Show resolved
Hide resolved
conniey
reviewed
Nov 25, 2019
...ssaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubMessageSerializer.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Nov 25, 2019
...venthubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/Messages.java
Show resolved
Hide resolved
added 2 commits
November 25, 2019 20:33
# Conflicts: # sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubConsumerAsyncClient.java # sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubPartitionAsyncConsumer.java # sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubProducerAsyncClient.java
- proposal implementation for azure-messaging-eventhubs - incorporated first round of review issues - resolve merge conflicts - remove unused message keys
Contributor
Author
|
could you please review the resolved issues again? many thanks |
conniey
reviewed
Nov 26, 2019
Member
conniey
left a comment
conniey
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments. :)
...ssaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubMessageSerializer.java
Outdated
Show resolved
Hide resolved
...ssaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubMessageSerializer.java
Outdated
Show resolved
Hide resolved
...venthubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/Messages.java
Outdated
Show resolved
Hide resolved
- incorporated review issues
conniey
approved these changes
Nov 27, 2019
Member
|
Thanks! |
xseeseesee
pushed a commit
that referenced
this pull request
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.