Skip to content

Conversation

@hemanttanwar
Copy link
Contributor

@hemanttanwar hemanttanwar commented Nov 23, 2019

Rollingback RequestIDPolicy( Supplier ) API as we need more time to speak to AppConfig Service team on their requirement.
So we will remove this API for now and design it with more discussion..

@JonathanGiles
Copy link
Member

How does this impact Azure Search?

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to document why AppConfig can't use this approach and document their usecase clearly which helps in designing this.

@hemanttanwar hemanttanwar merged commit 81b99a5 into Azure:master Nov 25, 2019
@hemanttanwar hemanttanwar deleted the 6217-rollback-requestid-policy branch November 25, 2019 09:04
@brjohnstmsft
Copy link
Member

FYI @navalev @itye-msft

@hemanttanwar
Copy link
Contributor Author

hemanttanwar commented Nov 25, 2019

How does this impact Azure Search?

@JonathanGiles I spoke to azure-search team before merging about their urgency and reconsider design . The can wait for us to consider AppConfig requirement as well and design which is acceptable to both of the services. I spoke to Shawn also Friday as well as on Monday AM to finalize the requirement and interface what he wanted.

I wanted optimal change in RequestIDPolicy which work for both of the services.
@mssfang

Next Step : I am working with Shawn to solidify AppConfig interface and get a RequestIDPolicy which work for both of the team in few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants