Cosmos: clean test gates #6373
Merged
Cosmos: clean test gates #6373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from Main.java, and attempted to address a memory leak in the RntbdRequestTimer
…ure-sdk-for-java into feature/cosmos/v4
…n long or int value should specify units
…_RESOLUTION_IN_NANOS from 5 to 100 ms in the hopes of resolving a performance issue on Windows
…d Mono.empty() and instead used ValueHolder<>(null)
…perations test failure which resulted from an incorrectly formed expected result string. Also: Removed unnecessary Ignore annotation imports.
…aThapar/azure-sdk-for-java into issue/#6289/cosmos/V4/assess-test-issues
…e might or might not keep the renames.
…ogs. We might or might not keep the renames.
…k-for-java into issue/#6289/cosmos/V4/assess-test-issues
Author
|
/azp run java - cosmos - tests |
|
Pull request contains merge conflicts. |
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
November 16, 2019 10:28
…test because it is configured to use BoundedStaleness consistency.
… test timeout by bumping TIMEOUT as well as SETUP_TIMEOUT interval from 60 to 120 seconds
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… test timeout on Emulator runs by moving the queryLargeDocuments test out of the emulator group into the simple group.
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
November 17, 2019 21:38
…inely timeout during intialization on compute/memory constrained systems like CI
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…yTest which itermittently times out in CI environments.
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…egy for before_ParallelDocumentQueryTest which itermittently fails due to a 503 on a query operation in CI environments.
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
David-Noble-at-work
requested review from
kushagraThapar and
moderakh
as code owners
David-Noble-at-work
changed the title
moderakh
reviewed
Nov 21, 2019
| /// <returns>List of effective partition key ranges for a collection or null if collection doesn't exist.</returns> | ||
| Mono<List<PartitionKeyRange>> tryGetOverlappingRangesAsync(String collectionResourceId, Range<String> range, | ||
| boolean forceRefresh /* = false */, Map<String, Object> properties); | ||
| Mono<Utils.ValueHolder<List<PartitionKeyRange>>> tryGetOverlappingRangesAsync(String collectionResourceId, Range<String> range, |
Contributor
There was a problem hiding this comment.
This changes already are already merged:
#6312
Are there more changes? or the branch is stale? could you merge the source branch back to your branch
moderakh
suggested changes
Nov 21, 2019
|
|
||
| @BeforeClass(groups = { "simple" }, timeOut = SETUP_TIMEOUT) | ||
| public void beforeClass() throws URISyntaxException, IOException { | ||
| public void before_CosmosPartitionKeyTests() throws URISyntaxException, IOException { |
Contributor
There was a problem hiding this comment.
any reason for renaming this method to before_CosmosPartitionKeyTests
If we are changing the test name pattern for beforeClass we should be consistent everywhere.
on the other test class you changed to before_CosmosSyncStoredProcTest
If this change is needed could you be consistent on "test" vs "tests"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6289 and the test results that follow.]