Certificates api changes #6309
Merged
Certificates api changes #6309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfree
added
Client
joshfree
approved these changes
Nov 13, 2019
...t-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java
Outdated
Show resolved
Hide resolved
...t-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java
Outdated
Show resolved
Hide resolved
| * Expiry date in UTC. | ||
| */ | ||
| private OffsetDateTime expires; | ||
| private OffsetDateTime expiresOn; |
Member
There was a problem hiding this comment.
can you confirm that we landed on "On" and not "At"
Member
Author
There was a problem hiding this comment.
KV is using "On" suffix across all languages.
Storage and Identity too use "On" suffix, I believe.
samvaity
reviewed
Nov 13, 2019
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...t-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java
Show resolved
Hide resolved
...certificates/src/main/java/com/azure/security/keyvault/certificates/OrganizationDetails.java
Show resolved
Hide resolved
...ficates/src/main/java/com/azure/security/keyvault/certificates/models/CertificateIssuer.java
Outdated
Show resolved
Hide resolved
heaths
approved these changes
Nov 13, 2019
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
A few comments, both otherwise LGTM.
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...ates/src/main/java/com/azure/security/keyvault/certificates/models/AdministratorContact.java
Outdated
Show resolved
Hide resolved
...ficates/src/main/java/com/azure/security/keyvault/certificates/models/CertificateIssuer.java
Outdated
Show resolved
Hide resolved
...ficates/src/main/java/com/azure/security/keyvault/certificates/models/CertificatePolicy.java
Show resolved
Hide resolved
heaths
approved these changes
Nov 19, 2019
...t-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java
Outdated
Show resolved
Hide resolved
...ates/src/main/java/com/azure/security/keyvault/certificates/models/AdministratorContact.java
Outdated
Show resolved
Hide resolved
samvaity
approved these changes
Nov 19, 2019
Member
samvaity
left a comment
samvaity
left a comment
There was a problem hiding this comment.
Would there be a review again in the API review tool after this is merged?
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
| } catch (RuntimeException ex) { | ||
| return monoError(logger, ex); | ||
| } | ||
| public PollerFlux<DeletedCertificate, Void> beginDeleteCertificate(String name) { |
Member
There was a problem hiding this comment.
same here, can return an NPE if status is null or if any of the three other than the mentioned ones and passed to the PollResponse<>
Member
Author
There was a problem hiding this comment.
for delete case, non-null status is returned in all cases.
Member
There was a problem hiding this comment.
Service will always return a non-null status. But here we initialize the status variable to null and only update it if the service returned status is either inProgress, completed or failed. But if it is not any of those we keep the status value as null and that is further passed to PollResponse which expects a non-null status.
Member
Author
There was a problem hiding this comment.
updated the default case in switch statement to parse a response other than those three, but that state should not hit ideally, as service should not emit any other status than those three.
...t-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
...t-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java
Outdated
Show resolved
Hide resolved
...certificates/src/main/java/com/azure/security/keyvault/certificates/OrganizationDetails.java
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Outdated
Show resolved
Hide resolved
...tificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6285 , #6408