DR fix for V4 #6271
Merged
DR fix for V4 #6271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
kushagraThapar and
moderakh
as code owners
Member
Author
|
/azp run java - cosmos - tests |
|
Pull request contains merge conflicts. |
Member
Author
|
Closing for merge conflict |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
approved these changes
Nov 22, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
I am signing off.
- Please make sure the same fail over test you ran for this PR elsewhere, works on this PR
- Also please ask someone from HA team to sign off on the changes.
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
added
Cosmos
cosmos:v4-item
kushagraThapar
approved these changes
Dec 7, 2019
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
LGTM.
@simplynaveen20 mentioned Ji and Vinh confirmed the changes.
CI shows some query test failures, which are known.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting PR from V3 #6139