Cosmos: CFP fixes and port consistency policy bug fix #6148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Nov 4, 2019
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
I have added a couple of suggestions, otherwise looks good.
...java/com/azure/data/cosmos/internal/changefeed/implementation/DocumentServiceLeaseStore.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/azure/data/cosmos/internal/changefeed/implementation/LeaseRenewerImpl.java
Outdated
Show resolved
Hide resolved
kushagraThapar
approved these changes
Nov 4, 2019
...java/com/azure/data/cosmos/internal/changefeed/implementation/DocumentServiceLeaseStore.java
Outdated
Show resolved
Hide resolved
...java/com/azure/data/cosmos/internal/changefeed/implementation/DocumentServiceLeaseStore.java
Outdated
Show resolved
Hide resolved
moderakh
suggested changes
Nov 4, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
@milismsft, Does the read my writes tests pass as of now against a strong / multi region strong account?
...osmos/src/main/java/com/azure/data/cosmos/internal/directconnectivity/ConsistencyWriter.java
Outdated
Show resolved
Hide resolved
...osmos/src/main/java/com/azure/data/cosmos/internal/directconnectivity/ConsistencyWriter.java
Outdated
Show resolved
Hide resolved
...zure-cosmos/src/main/java/com/azure/data/cosmos/internal/directconnectivity/StoreReader.java
Outdated
Show resolved
Hide resolved
...zure-cosmos/src/main/java/com/azure/data/cosmos/internal/directconnectivity/StoreReader.java
Outdated
Show resolved
Hide resolved
Contributor
|
@milismsft Please run all the tests. We need to run all the tests for checkin. I see only emulator tests above. |
Contributor
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
moderakh
reviewed
Nov 5, 2019
...osmos/src/main/java/com/azure/data/cosmos/internal/directconnectivity/ConsistencyWriter.java
Outdated
Show resolved
Hide resolved
moderakh
approved these changes
Nov 6, 2019
Contributor
|
This needs to be ported to v4 @kushagraThapar |
milismsft
added a commit
to milismsft/azure-sdk-for-java
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeFeedProcessor; fixes and extra logging related to the creations of the lease documents.
Port consistency policy bug fix (see Azure/azure-cosmosdb-java#196)
Port test fixes (see Azure/azure-cosmosdb-java#196)