Set resourceResponse in CosmosResponse #6076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parent CosmosResponse class
|
|
||
| CosmosContainerResponse(CosmosAsyncContainerResponse response, CosmosDatabase database, CosmosClient client) { | ||
| super(response.getProperties()); | ||
| super(response.resourceResponseWrapper, response.getProperties()); |
Member
There was a problem hiding this comment.
Won't sending wrapper out break design abstractions?
Or what should be the right abstraction.
Member
Author
There was a problem hiding this comment.
wrapper is already being used in all the public API classes as to fetch the properties. This won't break out the abstraction design.
This will just make sure to assign the wrapper in the parent class from the response object.
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync responses were not setting resourceResponse in parent class
CosmosResponseThis was causing sync responses to throw NPE in a bunch of methods like
getRequestLatency()getRequestCharge()and almost every other method.