Issues/consistent name changes

eng/code-quality-reports/src/main/java/com/azure/tools/checkstyle/checks/DisallowedWordsCheck.java

@@ -0,0 +1,129 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.tools.checkstyle.checks;
+
+import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
+import com.puppycrawl.tools.checkstyle.api.DetailAST;
+import com.puppycrawl.tools.checkstyle.api.TokenTypes;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+public class DisallowedWordsCheck extends AbstractCheck {
+    private Set<String> disallowedWords = new HashSet<>(Arrays.asList());
+    private String errorMessage = "%s, All Public API Classes, Fields and Methods should follow " +
+        "Camelcase standards for the following words: %s.";
+
+    /**
+     * Adds words that Classes, Methods and Variables that should follow Camelcasing standards
+     * @param disallowedWords words that should follow normal Camelcasing standards
+     */
+    public final void setDisallowedWords(String... disallowedWords) {
+        if (disallowedWords != null) {
+            Collections.addAll(this.disallowedWords, disallowedWords);
+        }
+    }
+
+    @Override
+    public int[] getDefaultTokens() {
+        return getRequiredTokens();
+    }
+
+    @Override
+    public int[] getAcceptableTokens() {
+        return getRequiredTokens();
+    }
+
+    @Override
+    public int[] getRequiredTokens() {
+        return new int[] {TokenTypes.CLASS_DEF,
+        TokenTypes.VARIABLE_DEF,
+        TokenTypes.METHOD_DEF};
+    }
+
+    @Override
+    public void visitToken(DetailAST token) {
+        switch (token.getType()) {
+            case TokenTypes.CLASS_DEF:
+            case TokenTypes.METHOD_DEF:
+                if (isPublicAPI(token)) {
+                    String tokenName = token.findFirstToken(TokenTypes.IDENT).getText();
+                    boolean found = getDisallowedWords(tokenName);
+                    if (found) {
+                        log(token, String.format(errorMessage, tokenName, this.disallowedWords.stream().collect(Collectors.joining(", ", "", ""))));
+                    }
+                }
+                break;
+            default:
+                // Checkstyle complains if there's no default block in switch
+                break;
+        }
+    }
+
+    /**
+     * Should we check member with given modifiers.
+     *
+     * @param token
+     *                modifiers of member to check.
+     * @return true if we should check such member.
+     */
+    private boolean isPublicAPI(DetailAST token) {
+        final DetailAST modifiersAST =
+            token.findFirstToken(TokenTypes.MODIFIERS);
+        final boolean isStatic = modifiersAST.findFirstToken(TokenTypes.LITERAL_STATIC) != null;
+        final boolean isPublic = modifiersAST
+            .findFirstToken(TokenTypes.LITERAL_PUBLIC) != null;
+        final boolean isProtected = modifiersAST.findFirstToken(TokenTypes.LITERAL_PROTECTED) != null;
+        return (isPublic || isProtected) && !isStatic;
+    }
+
+    /**
+     * Gets the disallowed abbreviation contained in given String.
+     * @param tokenName
+     *        the given String.
+     * @return the disallowed abbreviation contained in given String as a
+     *         separate String.
+     */
+    private boolean getDisallowedWords(String tokenName) {
+        boolean result = false;
+        for (String disallowedWord : disallowedWords) {
+            if (tokenName.contains(disallowedWord)) {
+                result = true;
+                break;
+            }
+        }
+        return result;
+    }
+
+    /**
+     * Get Abbreviation if it is illegal, where {@code beginIndex} and {@code endIndex} are
+     * inclusive indexes of a sequence of consecutive upper-case characters.
+     * @param tokenName name
+     * @param beginIndex begin index
+     * @param endIndex end index
+     * @return the abbreviation if it is bigger than required and not in the
+     *         ignore list, otherwise {@code null}
+     */
+    private String getAbbreviationIfIllegal(String tokenName, int beginIndex, int endIndex) {
+        String result = null;
+        final String abbr = getAbbreviation(tokenName, beginIndex, endIndex);
+        if (disallowedWords.contains(abbr)) {
+            result = abbr;
+        }
+        return result;
+    }
+
+    private static String getAbbreviation(String tokenName, int beginIndex, int endIndex) {
+        String result;
+        if (endIndex == tokenName.length() - 1) {
+            result = tokenName.substring(beginIndex);
+        } else {
+            result = tokenName.substring(beginIndex, endIndex);
+        }
+        return result;
+    }
+}

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle.xml

@@ -378,6 +378,16 @@ page at http://checkstyle.sourceforge.net/config.html -->
     4) All classes should use ClientLogger as logger only but except ClientLogger itself -->
     <module name="com.azure.tools.checkstyle.checks.GoodLoggingCheck"/>
 
+    <!-- CUSTOM CHECKS -->
+    <!-- Public API classes should follow Camelcase rules: -->
+    <!-- 1. ClassName -->
+    <!-- 2. methodName -->
+    <!-- 3. variableName -->
+    <!-- 4. longerVariableOrMethodName -->
+    <!--<module name="com.azure.tools.checkstyle.checks.DisallowedWordsCheck">-->
+    <!--<property name="disallowedWords" value="URL, HTTP, XML, JSON, SAS, CPK" />-->
+    <!--</module>-->
+
     <!-- CUSTOM CHECKS -->
     <!-- Fluent method checks:
     (1) A method returns an instance of the class, and that have one parameter,

eng/code-quality-reports/src/test/java/com/azure/tools/checkstyle/checks/DisallowedWordsCheckTests.java

@@ -0,0 +1,62 @@
+package com.azure.tools.checkstyle.checks;
+
+import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
+import com.puppycrawl.tools.checkstyle.Checker;
+import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
+import com.puppycrawl.tools.checkstyle.api.CheckstyleException;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+public class DisallowedWordsCheckTests extends AbstractModuleTestSupport {
+    private static final String DISALLOWED_WORD_ERROR_MESSAGE = "%s, All Public API Classes, Fields and Methods should follow" +
+        " Camelcase standards for the following words: XML, HTTP, URL.";
+
+    private Checker checker;
+
+    @Before
+    public void prepare() throws Exception {
+        checker = prepareCheckStyleChecker();
+        checker.addListener(this.getBriefUtLogger());
+    }
+
+    @After
+    public void cleanup() {
+        checker.destroy();
+    }
+
+    @Override
+    protected String getPackageLocation() {
+        return "com/azure/tools/checkstyle/checks/DisallowedWordsChecks";
+    }
+
+    @Test
+    public void disallowedWordsTestData() throws Exception {
+        String[] expected = {
+            expectedErrorMessage(3, 5, String.format(DISALLOWED_WORD_ERROR_MESSAGE, "errorHTTPMethod")),
+            expectedErrorMessage(9, 5, String.format(DISALLOWED_WORD_ERROR_MESSAGE, "invalidXMLMethod"))
+        };
+        verify(checker, getPath("DisallowedWordsTestData.java"), expected);
+    }
+
+    private String expectedErrorMessage(int line, int column, String errorMessage) {
+        return String.format("%d:%d: %s", line, column, errorMessage);
+    }
+
+    private Checker prepareCheckStyleChecker() throws CheckstyleException {
+        Checker checker = new Checker();
+        checker.setModuleClassLoader(Thread.currentThread().getContextClassLoader());
+        checker.configure(prepareConfiguration());
+        return checker;
+    }
+
+    private DefaultConfiguration prepareConfiguration() {
+        DefaultConfiguration checks = new DefaultConfiguration("Checks");
+        DefaultConfiguration treeWalker = new DefaultConfiguration("TreeWalker");
+        DefaultConfiguration camelCaseCheck = new DefaultConfiguration(DisallowedWordsCheck.class.getCanonicalName());
+        camelCaseCheck.addAttribute("disallowedWords", "URL, HTTP, XML");
+        checks.addChild(treeWalker);
+        treeWalker.addChild(camelCaseCheck);
+        return checks;
+    }
+}

eng/code-quality-reports/src/test/resources/com/azure/tools/checkstyle/checks/DisallowedWordsChecks/DisallowedWordsTestData.java

@@ -0,0 +1,12 @@
+@JacksonXmlRootElement(localName = "File-SetHTTPHeaders-Headers")
+public class CamelCaseTestData {
+    public void errorHTTPMethod() { throw new RuntimeException("Error Messages."); }
+
+    public void validHttpMethod() { throw new RuntimeException("Error Messages."); }
+
+    public static void itIsAURLError() { throw new RuntimeException("Error Messages."); }
+
+    protected void invalidXMLMethod() { throw new RuntimeException("Error Messages."); }
+
+    private void shouldNotSearch() { throw new RuntimeException("Error Messages."); }
+}

sdk/core/azure-core-management/pom.xml

@@ -85,6 +85,12 @@
       <artifactId>slf4j-simple</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.azure</groupId>
+      <artifactId>azure-core-test</artifactId>
+      <version>1.0.0-preview.5</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
 </project>