API review changes. #5681
Merged
API review changes. #5681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
alzimmermsft,
gapra-msft,
jaschrep-msft and
rickle-msft
as code owners
gapra-msft
reviewed
Oct 3, 2019
| // TODO: (gapra) Fix put range from URL link. Service docs have not been updated to show this API | ||
| public Mono<Response<FileUploadRangeFromURLInfo>> uploadRangeFromURLWithResponse(long length, | ||
| long destinationOffset, long sourceOffset, URI sourceURI) { | ||
| public Mono<Response<FileUploadRangeFromUrlInfo>> uploadRangeFromURLWithResponse(long length, |
Member
There was a problem hiding this comment.
Are these method names also supposed to change?
Contributor
Author
There was a problem hiding this comment.
Good catch. Will make a change.
gapra-msft
approved these changes
Oct 3, 2019
Member
gapra-msft
left a comment
gapra-msft
left a comment
There was a problem hiding this comment.
Just made a comment about one of the method signatures in files. (you could probably also do it in another PR if it's a change that needs to be done)
Contributor
Author
@gapra I have searched over the files. Make changes to non autogen code. |
alzimmermsft
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address comments not related to autogen for queue and file.
#5676
#5670