Chrande/cosmos/v4 #5548
Chrande/cosmos/v4 #5548
Conversation
christopheranderson
requested review from
kushagraThapar and
moderakh
as code owners
christopheranderson
assigned
1hw7 and
kushagraThapar and unassigned
1hw7 and
kushagraThapar
christopheranderson
force-pushed
the
chrande/cosmos/v4
branch
from
e73aef2 to
695f3b7
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
christopheranderson
changed the base branch from
cosmos/v4
to
feature/cosmos/v4
|
/azp run java - cosmos - tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Adding @JonathanGiles to do a quick review as well |
.../microsoft-azure-cosmos-examples/src/main/java/com/azure/data/cosmos/examples/BasicDemo.java
Show resolved
Hide resolved
...mples/src/main/java/com/azure/data/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java
Show resolved
Hide resolved
...osoft-azure-cosmos-examples/src/main/java/com/azure/data/cosmos/examples/HelloWorldDemo.java
Outdated
Show resolved
Hide resolved
...osoft-azure-cosmos-examples/src/main/java/com/azure/data/cosmos/examples/HelloWorldDemo.java
Outdated
Show resolved
Hide resolved
...ples/src/main/java/com/azure/data/cosmos/rx/examples/multimaster/samples/ConflictWorker.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/ChangeFeedProcessor.java
Show resolved
Hide resolved
...mos/microsoft-azure-cosmos/src/main/java/com/azure/data/cosmos/ConflictResolutionPolicy.java
Outdated
Show resolved
Hide resolved
Moving microsoft-azure to azure
|
/azp run java - cosmos - tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JonathanGiles
left a comment
JonathanGiles
left a comment
There was a problem hiding this comment.
I've just reviewed the pom files and have some pretty big requests. Let's start there to try to get things into better shape.
sdk/cosmos/azure-cosmos/pom.xml
Outdated
There was a problem hiding this comment.
There is a large number of dependencies in here I would like to push back on for track two. These include commons-io, commons-validator, netty-, commons-, testng, assertj-core, log4j, guava, metrics-core, micrometer-core, rxjava, reactor-netty. Some of these may be fine, but we should start with a presumption of guilt for each of them and have them plead their innocence :)
There was a problem hiding this comment.
There is a large number of dependencies in here I would like to push back on for track two. These include commons-io, commons-validator, netty-, commons-, testng, assertj-core, log4j, guava, metrics-core, micrometer-core, rxjava, reactor-netty. Some of these may be fine, but we should start with a presumption of guilt for each of them and have them plead their innocence :)
Created an issue for this: #5667
sdk/cosmos/azure-cosmos/pom.xml
Outdated
There was a problem hiding this comment.
We need to get these configuration overrides out of here, so that checkstyle, spotbugs, etc can all run properly.
There was a problem hiding this comment.
We need to get these configuration overrides out of here, so that checkstyle, spotbugs, etc can all run properly.
Created a github issue: #5668
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Re-opened this PR for simplicity. Please continue here. |
|
/azp run java - cosmos - tests |
|
There are failing tests for V4 preview branch, we plan to fix them going forward before we GA: #5707 |
7 participants
Uh oh!
There was an error while loading. Please reload this page.