Fixing high CPU and memory leak in session pump #5493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccept session requests.
… creation timeout.
binzywu
approved these changes
Sep 25, 2019
Contributor
|
Add Hemant to the PR since he is looking at service bus track 2 |
Contributor
|
guys, this is an urgent fix we need to rollout. Please review it asap. I will push for the merge by end of today. |
mssfang
reviewed
Sep 26, 2019
|
|
||
| this.timedOutUpdateStateRequestsDaemon = () -> { | ||
| try { | ||
| if (CoreMessageReceiver.this.getIsClosed()) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (CoreMessageReceiver.this.getIsClosed()) | |
| if (CoreMessageReceiver.this.getIsClosed()) { | |
| ``` #Resolved |
mssfang
reviewed
Sep 26, 2019
| // CONTRACT: message should be delivered to the caller of MessageReceiver.receive() only from prefetched messages | ||
| this.returnMesagesLoopDaemon = () -> { | ||
| try { | ||
| if (CoreMessageReceiver.this.getIsClosed()) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (CoreMessageReceiver.this.getIsClosed()) | |
| if (CoreMessageReceiver.this.getIsClosed()) { | |
| ``` #Resolved |
Contributor
|
Just a few nit. LGTM |
mssfang
approved these changes
Sep 26, 2019
Member
|
/azp run java - servicebus - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session pump keeps trying to accept sessions and if a session is not available on the service, link creation will timeout. CoreMessageReceiver object is created, and then discarded as link creation fails. But the scheduled timer objects that are created in the constructor are not cancelled and after some time, there will too many timers taking CPU cycles and holding reference to CoreMessageRecevier objects preventing them from being garbage collected.