Move Specialized BlobClients to Specialized Package #5399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
JonathanGiles,
ms-ishiyam,
sima-zhu and
vhvb1989
and removed request for
ms-ishiyam
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/PostProcessor.java
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/URLParser.java
Outdated
Show resolved
Hide resolved
...azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobAsyncClientBase.java
Show resolved
Hide resolved
...rage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobClientBase.java
Show resolved
Hide resolved
| */ | ||
|
|
||
| final class BlobServiceSASSignatureValues { | ||
| public final class BlobServiceSASSignatureValues { |
Member
Author
There was a problem hiding this comment.
Not entirely certain if this should be moved into an implementation package or maintain becoming public API given all the documentation and methods in the class make it seem that it should be usable by a consumer of the library.
Member
There was a problem hiding this comment.
It might be best to make this all internal, the only way we want users to make a SAS is by calling the generateSAS methods on the clients.
Member
Author
There was a problem hiding this comment.
There is immediate work that needs to be done in regards to SAS token generation, will handle in that PR.
alzimmermsft
requested review from
conniey,
gapra-msft and
jaschrep-msft
as code owners
alzimmermsft
requested review from
mssfang,
rickle-msft and
srnagar
as code owners
conniey
reviewed
Sep 20, 2019
...b/src/main/java/com/azure/messaging/eventhubs/checkpointstore/blob/BlobPartitionManager.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/azure/messaging/eventhubs/checkpointstore/blob/BlobPartitionManager.java
Show resolved
Hide resolved
conniey
reviewed
Sep 20, 2019
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java
Outdated
Show resolved
Hide resolved
alzimmermsft
requested review from
hemanttanwar and
jianghaolu
as code owners
conniey
reviewed
Sep 24, 2019
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobClientBuilder.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Sep 24, 2019
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobClientBuilder.java
Outdated
Show resolved
Hide resolved
gapra-msft
approved these changes
Sep 26, 2019
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobURLParts.java
Outdated
Show resolved
Hide resolved
| */ | ||
|
|
||
| final class BlobServiceSASSignatureValues { | ||
| public final class BlobServiceSASSignatureValues { |
Member
There was a problem hiding this comment.
It might be best to make this all internal, the only way we want users to make a SAS is by calling the generateSAS methods on the clients.
…cialized package in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5381
Moves the specialized BlobClients, AppendBlobClient, BlockBlobClient, and PageBlobClient, into the specialized package within Azure Storage Blobs. Additionally, move any model classes that are tied to a specific specialized client.
Adds a BlobClientBase which is now the super class for BlobClient, AppendBlobClient, BlockBlobClient, and PageBlobClient instead of using BlobClient as the base as it had additional convenience methods that weren't needed in the specialized clients.