Skip to content

Enabling ignored query tests. Ported Queryplan and OffsetLimit#5365

Merged
mbhaskar merged 7 commits into
Azure:masterfrom
mbhaskar:enabling-query-tests
Nov 6, 2019
Merged

Enabling ignored query tests. Ported Queryplan and OffsetLimit#5365
mbhaskar merged 7 commits into
Azure:masterfrom
mbhaskar:enabling-query-tests

Conversation

@mbhaskar
Copy link
Copy Markdown
Member

@mbhaskar mbhaskar commented Sep 12, 2019 •
edited
Loading

Enabling the ignored query tests.
Ported query plan from V2: https://github.com/Azure/azure-cosmosdb-java/pull/111/files
Ported offset limit from V2: https://github.com/Azure/azure-cosmosdb-java/pull/234/files
Ported offset limit fix from V2: https://github.com/Azure/azure-cosmosdb-java/pull/256/files
Added additional test to consume all the docs from a collection using offset limit based paging: Azure/azure-cosmosdb-java#257

@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Sep 13, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Sep 13, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Oct 25, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 25, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Oct 28, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 28, 2019

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar
kushagraThapar approved these changes Oct 29, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added 1 suggestion, please implement it.

Comment thread .../microsoft-azure-cosmos/src/test/java/com/azure/data/cosmos/rx/OrderbyDocumentQueryTest.java Outdated
@mbhaskar
Fixing failing tests
173494d 
Disabling non value aggregates
@mbhaskar mbhaskar requested review from kushagraThapar and removed request for christopheranderson October 30, 2019 19:35
@mbhaskar
Porting offset limit support from V2
082b399 
Adding test to drain all the documents (Azure#257)
@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Oct 31, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 31, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Oct 31, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 31, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@mbhaskar mbhaskar changed the title Enabling ignored query tests. Enabling ignored query tests. Ported Queryplan and OffsetLimit Oct 31, 2019
@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Nov 1, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Nov 1, 2019

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar
kushagraThapar approved these changes Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

moderakh
moderakh reviewed Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaskar is ReadMyWrites test passing on this PR?

ReadMyWrites is a must for this PR. Please make sure it is running
The PR code looks good. thank you.

@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Nov 5, 2019

/azp run java - cosmos - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@moderakh
Copy link
Copy Markdown
Contributor

moderakh commented Nov 5, 2019

@mbhaskar which test is running ReadMyWrites? none is called that

@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Nov 5, 2019

@bhaskar is ReadMyWrites test passing on this PR?

ReadMyWrites is a must for this PR. Please make sure it is running
The PR code looks good. thank you.

-- Meters ----------------------------------------------------------------------
#Successful Operations
count = 50203
mean rate = 20.41 events/second
1-minute rate = 14.61 events/second
5-minute rate = 15.43 events/second
15-minute rate = 18.11 events/second
#Unsuccessful Operations
count = 0
mean rate = 0.00 events/second
1-minute rate = 0.00 events/second
5-minute rate = 0.00 events/second
15-minute rate = 0.00 events/second

@moderakh moderakh self-requested a review November 6, 2019 00:11
@mbhaskar
Copy link
Copy Markdown
Member Author

mbhaskar commented Nov 6, 2019

@mbhaskar which test is running ReadMyWrites? none is called that

E2E tests run ReadMyWrites

This is the o/p for HTTPs mode
-- Meters ----------------------------------------------------------------------
#Successful Operations
count = 207812
mean rate = 129.08 events/second
1-minute rate = 112.97 events/second
5-minute rate = 118.36 events/second
15-minute rate = 114.81 events/second
#Unsuccessful Operations
count = 0
mean rate = 0.00 events/second
1-minute rate = 0.00 events/second
5-minute rate = 0.00 events/second
15-minute rate = 0.00 events/second

@mbhaskar mbhaskar merged commit dc68713 into Azure:master Nov 6, 2019
This was referenced Nov 19, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

+1 more reviewer

@moderakh moderakh moderakh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbhaskar @moderakh @kushagraThapar