OpenCensus Tracing Plugin Package Cleanup #5288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
conniey,
hemanttanwar,
jianghaolu,
mitchdenny,
mssfang,
samvaity and
srnagar
as code owners
conniey
reviewed
Sep 6, 2019
...acing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/ListOperationsAsync.java
Outdated
Show resolved
Hide resolved
...ore-tracing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/PublishEvents.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Sep 7, 2019
...zure-messaging-eventhubs/src/test/java/com/azure/messaging/eventhubs/EventProcessorTest.java
Outdated
Show resolved
Hide resolved
conniey
requested changes
Sep 9, 2019
...ore-tracing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/PublishEvents.java
Outdated
Show resolved
Hide resolved
Member
|
Wait for #5347 to be merged first please |
joshfree
approved these changes
Sep 11, 2019
samvaity
force-pushed
the
AzTracing_READMEChanges
branch
2 times, most recently
from
9645d25 to
52de6d2
Compare
samvaity
force-pushed
the
AzTracing_READMEChanges
branch
3 times, most recently
from
9f78227 to
f0cbeea
Compare
conniey
requested changes
Sep 25, 2019
eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
Outdated
Show resolved
Hide resolved
...ore-tracing-opencensus/src/main/java/com/azure/core/tracing/opencensus/OpenCensusTracer.java
Outdated
Show resolved
Hide resolved
...e-core-tracing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/HelloWorld.java
Outdated
Show resolved
Hide resolved
...e-tracing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/HelloWorldAsync.java
Outdated
Show resolved
Hide resolved
...e-tracing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/HelloWorldAsync.java
Outdated
Show resolved
Hide resolved
...acing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/ListOperationsAsync.java
Outdated
Show resolved
Hide resolved
conniey
requested changes
Sep 26, 2019
...ore-tracing-opencensus/src/main/java/com/azure/core/tracing/opencensus/OpenCensusTracer.java
Outdated
Show resolved
Hide resolved
...e-tracing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/HelloWorldAsync.java
Outdated
Show resolved
Hide resolved
...acing-opencensus/src/samples/java/com/azure/core/tracing/opencensus/ListOperationsAsync.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
AzTracing_READMEChanges
branch
2 times, most recently
from
1d36e15 to
7be0976
Compare
samvaity
force-pushed
the
AzTracing_READMEChanges
branch
from
1840d1c to
ed41524
Compare
conniey
reviewed
Sep 27, 2019
...ore-tracing-opencensus/src/main/java/com/azure/core/tracing/opencensus/OpenCensusTracer.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
AzTracing_READMEChanges
branch
from
52561a0 to
216c8e3
Compare
conniey
approved these changes
Sep 27, 2019
Contributor
|
@alzimmermsft I have a question about the name change that was done here. We'd gone from com.azure:tracing-opentelemetry to com.azure:azure-core-tracing-opencensus but shouldn't this have been azure-tracing-opencensus? All of our other names are azure-area-subarea1... for example azure-identity or azure-keyvault-keys, the fact that we're azure-core-tracing-opencensus kind of implies that this is a core module and not a tracing module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package name and documentation for the OpenCensus Tracing plugin package.