Skip to content

Update Swagger Transform to Use Correct Return Type #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 1 commit into from
Aug 26, 2019
Merged

Update Swagger Transform to Use Correct Return Type #5109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...zure-storage-file/src/main/java/com/azure/storage/file/implementation/DirectorysImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@
import com.azure.storage.file.models.DirectorysSetMetadataResponse;
import com.azure.storage.file.models.DirectorysSetPropertiesResponse;
import com.azure.storage.file.models.StorageErrorException;
import reactor.core.publisher.Mono;

import java.util.Map;
import reactor.core.publisher.Mono;

/**
* An instance of this class provides access to all the operations defined in
Expand Down
39 changes: 9 additions & 30 deletions ...e/azure-storage-file/src/main/java/com/azure/storage/file/models/FileDownloadHeaders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,19 +197,19 @@ public final class FileDownloadHeaders {
* Creation time for the file.
*/
@JsonProperty(value = "x-ms-file-creation-time")
private DateTimeRfc1123 fileCreationTime;
private OffsetDateTime fileCreationTime;

/*
* Last write time for the file.
*/
@JsonProperty(value = "x-ms-file-last-write-time")
private DateTimeRfc1123 fileLastWriteTime;
private OffsetDateTime fileLastWriteTime;

/*
* Change time for the file.
*/
@JsonProperty(value = "x-ms-file-change-time")
private DateTimeRfc1123 fileChangeTime;
private OffsetDateTime fileChangeTime;

/*
* Key of the permission set for the file.
Expand Down Expand Up @@ -830,10 +830,7 @@ public FileDownloadHeaders fileAttributes(String fileAttributes) {
* @return the fileCreationTime value.
*/
public OffsetDateTime fileCreationTime() {
if (this.fileCreationTime == null) {
return null;
}
return this.fileCreationTime.dateTime();
return this.fileCreationTime;
}

/**
Expand All @@ -843,11 +840,7 @@ public OffsetDateTime fileCreationTime() {
* @return the FileDownloadHeaders object itself.
*/
public FileDownloadHeaders fileCreationTime(OffsetDateTime fileCreationTime) {
if (fileCreationTime == null) {
this.fileCreationTime = null;
} else {
this.fileCreationTime = new DateTimeRfc1123(fileCreationTime);
}
this.fileCreationTime = fileCreationTime;
return this;
}

Expand All @@ -857,10 +850,7 @@ public FileDownloadHeaders fileCreationTime(OffsetDateTime fileCreationTime) {
* @return the fileLastWriteTime value.
*/
public OffsetDateTime fileLastWriteTime() {
if (this.fileLastWriteTime == null) {
return null;
}
return this.fileLastWriteTime.dateTime();
return this.fileLastWriteTime;
}

/**
Expand All @@ -870,11 +860,7 @@ public OffsetDateTime fileLastWriteTime() {
* @return the FileDownloadHeaders object itself.
*/
public FileDownloadHeaders fileLastWriteTime(OffsetDateTime fileLastWriteTime) {
if (fileLastWriteTime == null) {
this.fileLastWriteTime = null;
} else {
this.fileLastWriteTime = new DateTimeRfc1123(fileLastWriteTime);
}
this.fileLastWriteTime = fileLastWriteTime;
return this;
}

Expand All @@ -884,10 +870,7 @@ public FileDownloadHeaders fileLastWriteTime(OffsetDateTime fileLastWriteTime) {
* @return the fileChangeTime value.
*/
public OffsetDateTime fileChangeTime() {
if (this.fileChangeTime == null) {
return null;
}
return this.fileChangeTime.dateTime();
return this.fileChangeTime;
}

/**
Expand All @@ -897,11 +880,7 @@ public OffsetDateTime fileChangeTime() {
* @return the FileDownloadHeaders object itself.
*/
public FileDownloadHeaders fileChangeTime(OffsetDateTime fileChangeTime) {
if (fileChangeTime == null) {
this.fileChangeTime = null;
} else {
this.fileChangeTime = new DateTimeRfc1123(fileChangeTime);
}
this.fileChangeTime = fileChangeTime;
return this;
}

Expand Down
3 changes: 3 additions & 0 deletions sdk/storage/azure-storage-file/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,9 @@ directive:
op.get.responses["200"].headers["x-ms-file-creation-time"].format = "date-time";
op.get.responses["200"].headers["x-ms-file-last-write-time"].format = "date-time";
op.get.responses["200"].headers["x-ms-file-change-time"].format = "date-time";
op.get.responses["206"].headers["x-ms-file-creation-time"].format = "date-time";
op.get.responses["206"].headers["x-ms-file-last-write-time"].format = "date-time";
op.get.responses["206"].headers["x-ms-file-change-time"].format = "date-time";
op.head.responses["200"].headers["x-ms-file-creation-time"].format = "date-time";
op.head.responses["200"].headers["x-ms-file-last-write-time"].format = "date-time";
op.head.responses["200"].headers["x-ms-file-change-time"].format = "date-time";
Expand Down