Enabling Cosmos for Unified Pipelines#5102
Merged
mitchdenny merged 4 commits intoAzure:masterfrom Aug 27, 2019
Merged
Conversation
Contributor
Author
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - cosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - cosmos |
|
Azure Pipelines failed to run 1 pipeline(s). |
Contributor
Author
|
/azp run java - cosmos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@HarshaNalluru pinging you on this PR because this is an example of how I am going to "normalize" the cosmos pipeline in the JS repo so I wanted to give you a heads up since the JS repo is probably that next one I'll tackle after finishing the Java repo. |
Contributor
Author
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
reviewed
Aug 27, 2019
| Agent.Source.Git.ShallowFetchDepth: 1 | ||
| skipComponentGovernanceDetection: true No newline at end of file | ||
| skipComponentGovernanceDetection: true | ||
| EmulatorMsiUrl: 'https://acpedaily1.blob.core.windows.net/emulator/azure-cosmos-emulator.msi' No newline at end of file |
Member
There was a problem hiding this comment.
Why would this go into the shared globals file?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the existing Cosmos PR validation into the full unified pipeline model. One of the things that I anticipated when I introduced the
archetype-sdk-client.ymltemplate names was that we would have builds that break the mold and we would need other files. In these scenarios we introduce another template with the name[service]-sdk-client.yml. This file is mostly the same as the archetype template but has any additional ingredients embedded. This means that we can mostly push down the complexity of a particular service into a seperate file and not clutter up theci.ymlfile.That is why this change includes a new template file which is referenced by the
sdk/cosmos/ci.ymlfile - everything else is that file is the same, but theeng/pipelines/templates/stages/cosmos-sdk-client.ymlfile contains all the complexity that had shown up in the original version of theci.ymlfile.