Skip to content

Fixed Exception Loading Configurations #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 1 commit into from
Aug 8, 2019
Merged

Fixed Exception Loading Configurations #4853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sdk/core/azure-core/src/main/java/com/azure/core/util/configuration/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,19 @@ private <T> T convertOrDefault(String value, T defaultValue) {
*/
private boolean loadFrom(String name, Function<String, String> loader, String logMessage) {
String value = loader.apply(name);
if (!ImplUtils.isNullOrEmpty(value) && !value.equals(configurations.get(name))) {

if (value == null) {
// Nothing was loaded
return false;
} else if (value.equals(configurations.get(name))) {
// Value loaded is the same, no need to log anything.
return true;
} else {
// Value changed, log it!
configurations.put(name, value);
logger.info(logMessage, name, value);
return true;
}

return false;
}

/*
Expand Down