[AutoPR azure-resourcemanager-containerservicefleet]-generated-from-SDK Generation - Java-5926808#48117
Conversation
…osoft.ContainerService/fleet/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'd3e85dfd3b82ed7f275dc987656a65afda20a8f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5926808 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Updates the azure-resourcemanager-containerservicefleet management SDK (TypeSpec-generated) to align with 2025-08-01-preview by adding optional paging/filter parameters to several “list by fleet” operations, and refreshes the generated tests/samples/docs accordingly.
Changes:
- Adds
$top,$skipToken, and (where applicable)$filterparameters to multiple list operations across models, fluent interfaces, and REST client implementations. - Updates generated Java samples and mock tests to use the new method signatures.
- Updates metadata/docs (tsp-location, README version, changelog content).
Reviewed changes
Copilot reviewed 29 out of 44 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/tsp-location.yaml | Updates the spec directory/commit pointer used for generation. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/UpdateRunsDeleteMockTests.java | Updates mock test to match updated API surface. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/GatesListByFleetMockTests.java | Updates list call + assertions for new signature/fixture. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/FleetsListCredentialsWithResponseMockTests.java | Refreshes mock response and call parameters. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/FleetUpdateStrategiesListByFleetMockTests.java | Updates list call to include new paging parameters and refreshes assertions. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/FleetUpdateStrategiesGetWithResponseMockTests.java | Refreshes response fixture and request parameters. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/FleetUpdateStrategiesDeleteMockTests.java | Updates delete call parameters to match regenerated test data. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/FleetUpdateStrategiesCreateOrUpdateMockTests.java | Refreshes create/update payload and assertions for regenerated model content. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/FleetMembersDeleteMockTests.java | Updates delete call signature/parameters. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/test/java/com/azure/resourcemanager/containerservicefleet/generated/AutoUpgradeProfileOperationsGenerateUpdateRunMockTests.java | Refreshes fixture and request parameters. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/samples/java/com/azure/resourcemanager/containerservicefleet/generated/UpdateRunsListByFleetSamples.java | Updates samples to use new paging parameters (currently passed as null). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/samples/java/com/azure/resourcemanager/containerservicefleet/generated/GatesListByFleetSamples.java | Updates samples to include filter/top/skipToken parameters (currently null). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/samples/java/com/azure/resourcemanager/containerservicefleet/generated/FleetsListSamples.java | Updates subscription list sample to include top/skipToken parameters (currently null). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/samples/java/com/azure/resourcemanager/containerservicefleet/generated/FleetUpdateStrategiesListByFleetSamples.java | Updates samples for new listByFleet signature (top/skipToken). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/samples/java/com/azure/resourcemanager/containerservicefleet/generated/FleetMembersListByFleetSamples.java | Updates samples for new listByFleet signature (top/skipToken/filter). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/samples/java/com/azure/resourcemanager/containerservicefleet/generated/AutoUpgradeProfilesListByFleetSamples.java | Updates samples for new listByFleet signature (top/skipToken). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/models/UpdateRuns.java | Updates public model interface: listByFleet now includes top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/models/Gates.java | Updates public model interface: listByFleet now includes filter/top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/models/Fleets.java | Updates public model interface: list now includes top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/models/FleetUpdateStrategies.java | Updates public model interface: listByFleet now includes top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/models/FleetMembers.java | Updates public model interface: listByFleet now includes top/skipToken/filter. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/models/AutoUpgradeProfiles.java | Updates public model interface: listByFleet now includes top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/UpdateRunsImpl.java | Wires new listByFleet parameters through resource collection implementation. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/UpdateRunsClientImpl.java | Adds $top/$skipToken query params and new paging-aware list plumbing. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/GatesImpl.java | Wires filter/top/skipToken through to service client. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/GatesClientImpl.java | Adds $filter/$top/$skipToken query params and paging-aware list plumbing. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/FleetsImpl.java | Wires top/skipToken through to service client. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/FleetsClientImpl.java | Adds $top/$skipToken query params and paging-aware list plumbing for subscription list. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/FleetUpdateStrategiesImpl.java | Wires top/skipToken through to service client. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/FleetUpdateStrategiesClientImpl.java | Adds $top/$skipToken query params and paging-aware list plumbing. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/FleetMembersImpl.java | Wires top/skipToken/filter through to service client. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/FleetMembersClientImpl.java | Adds $top/$skipToken/$filter query params and paging-aware list plumbing. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/AutoUpgradeProfilesImpl.java | Wires top/skipToken through to service client. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/implementation/AutoUpgradeProfilesClientImpl.java | Adds $top/$skipToken query params and paging-aware list plumbing. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/fluent/UpdateRunsClient.java | Updates fluent interface listByFleet signature for new paging parameters. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/fluent/GatesClient.java | Updates fluent interface listByFleet signature for filter/top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/fluent/FleetsClient.java | Updates fluent interface list signature for top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/fluent/FleetUpdateStrategiesClient.java | Updates fluent interface listByFleet signature for top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/fluent/FleetMembersClient.java | Updates fluent interface listByFleet signature for top/skipToken/filter. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/src/main/java/com/azure/resourcemanager/containerservicefleet/fluent/AutoUpgradeProfilesClient.java | Updates fluent interface listByFleet signature for top/skipToken. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/pom.xml | Minor formatting change in the root <project> tag. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/SAMPLE.md | Updates embedded samples to new signatures (currently with explicit nulls). |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/README.md | Bumps dependency snippet version to 1.3.0-beta.3. |
| sdk/containerservicefleet/azure-resourcemanager-containerservicefleet/CHANGELOG.md | Records new beta version entries and API signature changes. |
| PagedIterable<FleetUpdateStrategy> listByFleet(String resourceGroupName, String fleetName, Integer top, | ||
| String skipToken, Context context); |
There was a problem hiding this comment.
This change removes the existing listByFleet(String, String, Context) overload. Since top/skipToken are optional, consider keeping the prior overload for compatibility and adding this new overload alongside it, delegating the old one with null paging values.
| PagedIterable<FleetMember> listByFleet(String resourceGroupName, String fleetName, Integer top, String skipToken, | ||
| String filter, Context context); |
There was a problem hiding this comment.
The listByFleet(String, String, Context) overload was removed in favor of a signature that includes optional paging/filter parameters. Consider keeping the old overload for backwards compatibility and convenience, delegating it to the new signature with top/skipToken/filter set to null.
| PagedIterable<AutoUpgradeProfile> listByFleet(String resourceGroupName, String fleetName, Integer top, | ||
| String skipToken, Context context); |
There was a problem hiding this comment.
This removes listByFleet(String, String, Context) and replaces it with a signature that includes optional paging parameters. To avoid a breaking change and reduce the need for callers/samples to pass nulls, consider reintroducing the previous overload and have it delegate to this new method with null top/skipToken.
| public static void listsTheAutoUpgradeProfileResourcesByFleet( | ||
| com.azure.resourcemanager.containerservicefleet.ContainerServiceFleetManager manager) { | ||
| manager.autoUpgradeProfiles().listByFleet("rg1", "fleet1", com.azure.core.util.Context.NONE); | ||
| manager.autoUpgradeProfiles().listByFleet("rg1", "fleet1", null, null, com.azure.core.util.Context.NONE); |
There was a problem hiding this comment.
The samples now pass multiple explicit null values for the newly added optional paging/filter parameters. This makes the sample harder to read and doesn’t explain what those parameters do. Consider either (a) using an overload that omits optional parameters (preferred if added for compatibility), or (b) updating the sample to pass meaningful example values (or add a short comment explaining that null means “use service default/no filtering”).
| # Release History | ||
|
|
||
| ## 1.3.0-beta.3 (Unreleased) | ||
| ## 1.3.0-beta.3 (2026-02-25) |
There was a problem hiding this comment.
The changelog top section was changed from “(Unreleased)” to a fixed release date. For in-progress SDK generation PRs, this repo typically keeps the top version marked as “(Unreleased)” until the actual release is cut; otherwise it can be misleading and complicates subsequent changelog automation. Consider reverting this header back to “## 1.3.0-beta.3 (Unreleased)” and leaving the date to be set during the release process.
| ## 1.3.0-beta.3 (2026-02-25) | |
| ## 1.3.0-beta.3 (Unreleased) |
| PagedIterable<UpdateRun> listByFleet(String resourceGroupName, String fleetName, Integer top, String skipToken, | ||
| Context context); |
There was a problem hiding this comment.
This change removes the existing overload listByFleet(String, String, Context) and replaces it with a signature that adds optional paging parameters. To avoid a breaking change (and to keep samples from having to pass explicit nulls), consider keeping the old overload and adding the new one, where the old overload delegates with top/skipToken set to null.
| PagedIterable<Gate> listByFleet(String resourceGroupName, String fleetName, String filter, Integer top, | ||
| String skipToken, Context context); |
There was a problem hiding this comment.
This update removes listByFleet(String, String, Context) and forces callers to pass optional parameters (often as null). Consider retaining the previous overload for source/binary compatibility and adding this expanded overload in addition, delegating the old overload with filter/top/skipToken as null.
| * @return the response of a Fleet list operation as paginated response with {@link PagedIterable}. | ||
| */ | ||
| PagedIterable<Fleet> list(Context context); | ||
| PagedIterable<Fleet> list(Integer top, String skipToken, Context context); |
There was a problem hiding this comment.
The list(Context) overload was removed and replaced with a method that requires top/skipToken. It would be better to keep list(Context) for compatibility and to avoid forcing callers to pass nulls when they only need to provide a Context; the overload can delegate to the new signature with null paging parameters.
Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'd3e85dfd3b82ed7f275dc987656a65afda20a8f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5926808 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=fd5c7709-d7cf-f011-bbd3-6045bd07ef68 Submitted by: ryan.zhang@microsoft.com
Release Plan Details
Spec pull request: Add 2025-08-01-preview azure-rest-api-specs#38919
Spec API version: 2025-08-01-preview