Sync-Wrapper for V3 Async SDK #4757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains synchronous operations for - Database - Container - Item operations Scripts, Users, Conflicts etc will be part of subsequent PR
Contributor
|
/azp run java - cosmos - tests |
|
Pull request contains merge conflicts. |
7 tasks
# Conflicts: # sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/CosmosClientBuilder.java # sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/rx/TestSuiteBase.java
moderakh
reviewed
Aug 8, 2019
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncClient.java
Show resolved
Hide resolved
sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/rx/TestSuiteBase.java
Show resolved
Hide resolved
sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/sync/CosmosSyncContainerTest.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/sync/CosmosSyncDatabaseTest.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/sync/CosmosSyncItemTest.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/sync/CosmosSyncItemTest.java
Outdated
Show resolved
Hide resolved
moderakh
reviewed
Aug 8, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
great job Bhaskar I added some minor comments.
sdk/cosmos/sdk/src/test/java/com/azure/data/cosmos/sync/CosmosSyncItemTest.java
Show resolved
Hide resolved
kushagraThapar
approved these changes
Aug 8, 2019
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
Minor comments, please implement them.
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/CosmosClientBuilder.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncClient.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncClient.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncDatabaseResponse.java
Show resolved
Hide resolved
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncItem.java
Show resolved
Hide resolved
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncItemResponse.java
Show resolved
Hide resolved
moderakh
reviewed
Aug 8, 2019
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/sync/CosmosSyncContainer.java
Outdated
Show resolved
Hide resolved
Implementing PR comments
moderakh
approved these changes
Aug 9, 2019
christopheranderson
approved these changes
Aug 12, 2019
sdk/cosmos/sdk/src/main/java/com/azure/data/cosmos/CosmosClientBuilder.java
Outdated
Show resolved
Hide resolved
| * Provides a client-side logical representation of the Azure Cosmos database service. | ||
| * SyncClient is used to perform operations in a synchronous way | ||
| */ | ||
| public class CosmosSyncClient { |
Contributor
There was a problem hiding this comment.
Suggested change
| public class CosmosSyncClient { | |
| public final class CosmosSyncClient { |
Based on guidelines, this should be final
Contributor
There was a problem hiding this comment.
if we make this final, then the neither the end user nor us can mock this for testing.
| * Instantiate the cosmos client builder to build cosmos client | ||
| * @return {@link CosmosClientBuilder} | ||
| */ | ||
| public static CosmosClientBuilder builder(){ |
Contributor
There was a problem hiding this comment.
(note for ADP folks: This doesn't match the guidelines, but it matches our existing pattern which we've gotten an exception for.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains synchronous operations for
Scripts, Users, Conflicts etc will be part of subsequent PR