Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12863 See eng/common workflow

Disable link checking guidelines for copilot instruction files.
Copilot AI review requested due to automatic review settings November 12, 2025 18:16
@azure-sdk azure-sdk requested a review from a team as a code owner November 12, 2025 18:16
@azure-sdk azure-sdk requested a review from weshaggard November 12, 2025 18:16
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the eng/common directory with azure-sdk-tools PR #12863, specifically modifying the link verification script to handle copilot instruction files differently. The change allows relative links in copilot instruction files while maintaining the general guidance checks for other documentation.

Key changes:

  • Introduces conditional disabling of checkLinkGuidance for files matching the pattern instructions.md$
  • Implements a save/restore mechanism for the checkLinkGuidance variable using try-finally

@azure-sdk azure-sdk merged commit a54ad60 into main Nov 12, 2025
22 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-weshaggard-patch-2-12863 branch November 12, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants