Skip to content

Retry overhaul #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
conniey merged 36 commits into from
Aug 1, 2019
Merged

Retry overhaul #4718

conniey merged 36 commits into from
Aug 1, 2019

Conversation

@conniey
Copy link
Member

@conniey conniey commented Jul 30, 2019 •
edited
Loading

This PR is an overhaul of the existing Retry for azure-core-amqp. In addition, we add support for retrying not just send, but for any operation (ie. when an AMQP connection, link, session fails for creation).

Features:

  • Renames Retry -> RetryPolicy to align with other language teams.
    • A lot of the changed files come from this file rename.
  • Adds RetryOptions
  • Removes .timeout() with RetryOptions.tryTimeout()
  • Moves BatchOptions into model package class (unrelated to retry).

Fixes #4262
Fixes #4308

conniey added 21 commits July 23, 2019 10:39
@conniey
Move BatchOptions into models package.
f727b25
@conniey
Move tests into their respective folders.
6a6e38f
@conniey
Add RetryOptions and RetryMode.
f0553dc
@conniey
Add test for RetryOptions.
88237af
@conniey
Rename Retry -> RetryPolicy
2917b48
@conniey
Update names for RetryOptions.
7017142
@conniey
Update RetryPolicy and ExponentialRetryPolicy to use new interface.
b77deaf
@conniey
Add test cases for equality. And fixing ExponentialRetryPolicy tests.
5209b38
@conniey
Fixing documentation error.
5579ef3
@conniey
Fix SpotBugs issue.
3e40f85
@conniey
Add @inheritDocs
1c61e79
@conniey
Updating RetryPolicy, adding FixedRetry and ExponentialRetry.
efe958b
@conniey
Adding documentation to RetryPolicy.
a605954
@conniey
Fix test cases for ExponentialRetryPolicy
c983b51
@conniey
Adding documentation for RetryPolicy.
5b879b3
@conniey
Add final
045b61c
@conniey
Remove RemainingTime from RetryPolicy. Only works in Send, but not ge…
9a136ab 
…neral retry.
@conniey
Adding tests for FixedRetryPolicy.
c4bad4c
@conniey
Add RetryOptionsUtil and TimeoutHandler.
9d6e66e
@conniey
Update tests to use RetryOptions and RetryUtil for retry with timeouts.
7894261
@conniey
Fixing test.
8614786
@conniey conniey added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jul 30, 2019
@conniey conniey requested a review from alzimmermsft as a code owner July 30, 2019 23:00
@conniey conniey self-assigned this Jul 30, 2019
srnagar
srnagar reviewed Jul 31, 2019
View reviewed changes
@conniey conniey merged commit 3474c06 into Azure:master Aug 1, 2019
@conniey conniey deleted the retry-per-send branch August 1, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srnagar srnagar srnagar left review comments

@joshfree joshfree joshfree approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@mssfang mssfang Awaiting requested review from mssfang

@ramya0820 ramya0820 Awaiting requested review from ramya0820

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

Assignees

@conniey conniey

Labels

Client This issue points to a problem in the data-plane of the library. Event Hubs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Event Hubs] Add fixed retry [Event Hubs] Add support for individual send message Retry

4 participants

@conniey @joshfree @JonathanGiles @srnagar