Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Oct 30, 2025

Configurations: 'specification/elasticsan/resource-manager/Microsoft.ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515647 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=e1ca6d7f-4cb5-f011-bbd2-6045bd07ef68 Submitted by: [email protected]

Release Plan Details

…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515647 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-elasticsan

@yifanz7 yifanz7 marked this pull request as ready for review October 30, 2025 06:37
Copilot AI review requested due to automatic review settings October 30, 2025 06:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Azure ElasticSAN Resource Manager SDK from AutoRest code generation to TypeSpec code generation. The changes involve updating the code generator from Microsoft (R) AutoRest to Microsoft (R) TypeSpec, along with API changes and test data updates.

Key Changes

  • Code generator migration from AutoRest to TypeSpec
  • Removal of deprecated API parameters (XMsAccessSoftDeletedResources, DeleteType, DeleteRetentionPolicy)
  • Updated test data with new mock values
  • Added new metadata files for TypeSpec support
  • Updated API version reference paths in sample code

Reviewed Changes

Copilot reviewed 143 out of 243 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Added new TypeSpec configuration file specifying the API spec location
Multiple test files Updated generator header comments and test mock data values
Multiple sample files Updated x-ms-original-file paths to new API version format
XMsAccessSoftDeletedResources.java Removed deprecated enum class
DeleteRetentionPolicyTests.java Removed test file for deprecated feature
ResourceProviderRestoreVolumeSamples.java Removed sample file for deprecated operation
module-info.java Added opens directive for implementation.models package
package-info.java files Updated service descriptions
Various model files Removed validate() method from VolumeUpdate
Metadata files Added new TypeSpec metadata and API view configuration files

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiaofeiCao
Would need your review

…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'e58a215d34c2f7fdf654cd4fd8511a90a94e56e9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5525976 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Nov 3, 2025

regen after update in specs to mitigate a breaking change due to naming in TypeSpec Azure/azure-rest-api-specs#38569

@yifanz7
Copy link
Member

yifanz7 commented Nov 13, 2025

As the server rollout is running into some issues, we're not able to have the release now.
@XiaofeiCao @weidongxu-microsoft @haolingdong-msft Could you please help hold the release till further confirmation? Thanks a lot!

@weidongxu-microsoft
Copy link
Member

As the server rollout is running into some issues, we're not able to have the release now. @XiaofeiCao @weidongxu-microsoft @haolingdong-msft Could you please help hold the release till further confirmation? Thanks a lot!

Upon TypeSpec, the PR and release is actually owned by you. As long as we don't have approval from service, we won't merge the PR. Also service would run the release after PR merge.

@github-actions
Copy link
Contributor

Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jan 16, 2026
@weidongxu-microsoft
Copy link
Member

@yifanz7
If you want to proceed, please approve the PR. It signifies that service is good with the PR, and we can merge it.

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jan 22, 2026
@yifanz7
Copy link
Member

yifanz7 commented Jan 29, 2026

@weidongxu-microsoft The server rollout is ready. Can we proceed with the release and target at the next release train by 2/27? Thanks!

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jan 29, 2026

@weidongxu-microsoft The server rollout is ready. Can we proceed with the release and target at the next release train by 2/27? Thanks!

We will proceed to merge the PR.

For the release, upon TypeSpec, service dev will trigger the release. The app (or the mcp agent) should have info on the release pipeline, and eng.ms should have info about how to run the pipeline.

@weidongxu-microsoft weidongxu-microsoft enabled auto-merge (squash) January 29, 2026 06:25
azure-sdk and others added 2 commits February 6, 2026 00:51
@weidongxu-microsoft weidongxu-microsoft enabled auto-merge (squash) February 6, 2026 01:23
@weidongxu-microsoft weidongxu-microsoft merged commit 7a21726 into Azure:main Feb 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants