-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[AutoPR azure-resourcemanager-elasticsan]-generated-from-SDK Generation - Java-5515647 #47122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR azure-resourcemanager-elasticsan]-generated-from-SDK Generation - Java-5515647 #47122
Conversation
…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515647 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Azure ElasticSAN Resource Manager SDK from AutoRest code generation to TypeSpec code generation. The changes involve updating the code generator from Microsoft (R) AutoRest to Microsoft (R) TypeSpec, along with API changes and test data updates.
Key Changes
- Code generator migration from AutoRest to TypeSpec
- Removal of deprecated API parameters (XMsAccessSoftDeletedResources, DeleteType, DeleteRetentionPolicy)
- Updated test data with new mock values
- Added new metadata files for TypeSpec support
- Updated API version reference paths in sample code
Reviewed Changes
Copilot reviewed 143 out of 243 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Added new TypeSpec configuration file specifying the API spec location |
| Multiple test files | Updated generator header comments and test mock data values |
| Multiple sample files | Updated x-ms-original-file paths to new API version format |
| XMsAccessSoftDeletedResources.java | Removed deprecated enum class |
| DeleteRetentionPolicyTests.java | Removed test file for deprecated feature |
| ResourceProviderRestoreVolumeSamples.java | Removed sample file for deprecated operation |
| module-info.java | Added opens directive for implementation.models package |
| package-info.java files | Updated service descriptions |
| Various model files | Removed validate() method from VolumeUpdate |
| Metadata files | Added new TypeSpec metadata and API view configuration files |
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XiaofeiCao
Would need your review
…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'e58a215d34c2f7fdf654cd4fd8511a90a94e56e9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5525976 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
regen after update in specs to mitigate a breaking change due to naming in TypeSpec Azure/azure-rest-api-specs#38569 |
|
As the server rollout is running into some issues, we're not able to have the release now. |
Upon TypeSpec, the PR and release is actually owned by you. As long as we don't have approval from service, we won't merge the PR. Also service would run the release after PR merge. |
|
Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
@yifanz7 |
|
@weidongxu-microsoft The server rollout is ready. Can we proceed with the release and target at the next release train by 2/27? Thanks! |
We will proceed to merge the PR. For the release, upon TypeSpec, service dev will trigger the release. The app (or the mcp agent) should have info on the release pipeline, and eng.ms should have info about how to run the pipeline. |
…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '26b4701e643f7ace8faf73b9acd5b205f2df2d7d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5845207 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Configurations: 'specification/elasticsan/resource-manager/Microsoft.ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515647 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=e1ca6d7f-4cb5-f011-bbd2-6045bd07ef68 Submitted by: [email protected]
Release Plan Details
Spec pull request: Stable version 2025-09-01 with prevalidation and autoscale changes azure-rest-api-specs#37218
Spec API version: 2025-09-01