Azure Storage Common Package #4658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue
Removes RawClients from Storage Blobs
…to ContainerClient (Azure#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient
* Initial check in for storage queue
* Finished the restructure, refactor builder. Added sleep in record feature. Linting
Merges AppendBlobClientBuilder, BlobClientBuilder, BlockBlobClientBuilder, and PageBlobClientBuilder into a single builder class BlobClientBuilder. Additionally, JavaDoc comments for the other builder classes, ContainerClientBuilder and StorageAccountClientBuilder, were cleaned up and the way the endpoint is handled in builders was changed.
alzimmermsft
added
Storage
alzimmermsft
requested review from
jaschrep-msft,
jianghaolu,
rickle-msft and
sima-zhu
This was referenced Jul 30, 2019
Member
Author
|
Closing this PR due to it being stale and having numerous irreconcilable merge conflict, opened #4918 in its place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4390, #4431, #4495, #4533, #4539, #4550
Creates a common package for Storage clients, cleans up some documentations, and adds consistency to client builders. Additionally, adds a way to set a HttpPipeline in client builders and adds OAuth support to Queues.