Move storage to sdk/storage #4655
Conversation
|
changes to |
mitchdenny
requested review from
JonathanGiles,
danieljurek,
jaschrep-msft,
joshfree,
rickle-msft,
sima-zhu and
weshaggard
as code owners
|
@mitchdenny please don't merge this without coordinating with @alzimmermsft @rickle-msft @jaschrep-msft as there are a few PRs still in flight this week for Preview 2 |
JonathanGiles
left a comment
JonathanGiles
left a comment
There was a problem hiding this comment.
Looks fine. Once this is done I'd be keen to get the eng/jacoco-test-coverage/pom.xml and eng/spotbugs-aggregate-report/pom.xml files updated to ensure that they are covering all of the storage code with spotbugs checks, test coverage checks, etc (something for @alzimmermsft probably). Also just make sure there are no opt-outs for any linting tool in the storage pom files.
joshfree
left a comment
joshfree
left a comment
There was a problem hiding this comment.
Could you also include an edit to the .github/CODEOWNERS file with this storage => sdk/storage PR?
Done! @alzimmermsft I discussed this restructuring work with you late last week - are you still good for me to land this change? |
|
Just rebased after some changes that came in. |
|
/azp run java - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Rebasing off master again due to conflicting changes. If this builds I'll merge it in. |
|
Rebased again :) |
5 participants
This PR moves
storagetosdk/storage. This is the final client/data-plane library we are moving before moving onto the management plane libraries.